PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Jul 2023

phan reports Type Mismatch - hope I fixed it correctly

plugins/schemaorg/blogposting/src/Extension/Blogposting.php:55 PhanTypeMismatchReturn Returning $this->cleanupDate($schema, ['datePublished','dateModified']) of type bool but customCleanup() is declared to return array plugins/schemaorg/book/src/Extension/Book.php:55 PhanTypeMismatchReturn Returning $this->cleanupDate($schema, ['datePublished']) of type bool but customCleanup() is declared to return array plugins/schemaorg/event/src/Extension/Event.php:55 PhanTypeMismatchReturn Returning $this->cleanupDate($schema, ['startDate']) of type bool but customCleanup() is declared to return array plugins/schemaorg/jobposting/src/Extension/JobPosting.php:57 PhanTypeMismatchReturn Returning $schema of type bool but customCleanup() is declared to return array plugins/schemaorg/recipe/src/Extension/Recipe.php:61 PhanTypeMismatchReturn Returning $schema of type bool but customCleanup() is declared to return array

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2023
Category Libraries
avatar brianteeman brianteeman - open - 25 Jul 2023
avatar brianteeman brianteeman - change - 25 Jul 2023
Status New Pending
avatar brianteeman brianteeman - change - 25 Jul 2023
Title
[5.0] scheaeorg return array
[5.0] schemaorg return array
avatar brianteeman brianteeman - edited - 25 Jul 2023
avatar brianteeman brianteeman - change - 25 Jul 2023
Labels Added: PR-5.0-dev
avatar brianteeman
brianteeman - comment - 25 Jul 2023

Phan no longer reports a typemismatch

avatar heelc29 heelc29 - test_item - 25 Jul 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 25 Jul 2023

I have tested this item successfully on 43a5ae8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41240.

avatar HLeithner HLeithner - change - 25 Jul 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-25 20:28:14
Closed_By HLeithner
avatar HLeithner HLeithner - close - 25 Jul 2023
avatar HLeithner HLeithner - merge - 25 Jul 2023
avatar HLeithner
HLeithner - comment - 25 Jul 2023

thanks

Add a Comment

Login with GitHub to post a comment