[#4124] - Deprecate MySQL driver based on deprecated PHP mysql extension
- Closed
- 18 Aug 2014
- Medium
- Build: 3.4-dev
- # 4124
- Diff
- mbabker:deprecate_mysql
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In PHP 5.5, support for the original mysql extension was deprecated. This affects our base MySQL driver class as it implements this extension. This PR will tag that class, and its supporting classes, as deprecated since PHP will presumably drop support for them at some point.
Future TODO - When PHP announces a version where this extension will be removed or become totally unsupported, the driver class should be updated to fail gracefully (through version checks and Exceptions) instead of throwing a fatal error due to the code not being present.
jissues-bot
- | Status | Pending | ⇒ | New |
| Labels |
Added:
?
?
|
||
Ya, but I try to not direct commit my own PRs and we can at least use this as a reference down the road as to why these classes are deprecated and removed when that day comes.
| Labels |
Added:
?
|
||
Marking RTC
dbhurley
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-18 13:53:03 |
There is nothing to really test here - cant it just be committed?