Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41236] - [5.0] Smart Search to show Contact images

Feature PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar sakiss
sakiss
25 Jul 2023

Summary of Changes

This is a follow up to #35612.
Smart Search now shows images only for the articles in the results .

With this PR images for the contacts (com_contact) can be shown as well.

Testing Instructions

  1. You need to have some contacts created (under Components > Contacts > Contacts).
    Your contacts need to have images.

  2. Go to the Smart Search and press the "Index" button.

  3. In the menu item for the Smart Search enable the setting Result Image .

  4. Now in the front-end use the Smart Search (menu item or module) and search for one of your contacts.

Actual result BEFORE applying this Pull Request

No image in the contact results.

Expected result AFTER applying this Pull Request

Contact images.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jul 2023
Category ⇒ Front End Plugins
avatar sakiss sakiss - open - 25 Jul 2023
avatar sakiss sakiss - change - 25 Jul 2023
Status New ⇒ Pending
avatar sakiss sakiss - change - 25 Jul 2023
The description was changed
avatar sakiss sakiss - edited - 25 Jul 2023
avatar sakiss sakiss - change - 25 Jul 2023
The description was changed
avatar sakiss sakiss - edited - 25 Jul 2023
avatar sakiss sakiss - change - 25 Jul 2023
The description was changed
avatar sakiss sakiss - edited - 25 Jul 2023
avatar sakiss sakiss - change - 25 Jul 2023
The description was changed
avatar sakiss sakiss - edited - 25 Jul 2023
avatar sakiss sakiss - change - 25 Jul 2023
The description was changed
avatar sakiss sakiss - edited - 25 Jul 2023
avatar sakiss sakiss - change - 25 Jul 2023
The description was changed
avatar sakiss sakiss - edited - 25 Jul 2023
avatar HLeithner
HLeithner - comment - 26 Jul 2023

pretty sure this have to go into 5.0

avatar sakiss
sakiss - comment - 26 Jul 2023

@HLeithner it's an already shipped feature since 4.1. Just a continuation of it.

avatar HLeithner
HLeithner - comment - 26 Jul 2023

It's not a bugfix so it's a new feature and new features go into the next minor version, since 4.4 is only a preparation release for 5.0 it has to go directly to 5.0.

We try to be more strict with changing code in bugfix releases to have more stable releases with no/less regressions.

avatar sakiss
sakiss - comment - 26 Jul 2023

How it's a new feature?
The images for the finder results were shipped back in J4.1 (see: #35612)
But were not complete.

I leave that to the RL decision

avatar obuisard
obuisard - comment - 26 Jul 2023

Thank you very much for the PR Sakis @sakiss.
We have discussed the PR in our latest maintenance meeting and consider this as an improvement that can only be included into a 'feature' release. I will rebase the PR to 5.0.

avatar sakiss sakiss - change - 15 Aug 2023
Title
…
Smart Search to show Contact images
[5.0] Smart Search to show Contact images
avatar sakiss sakiss - edited - 15 Aug 2023
avatar Quy Quy - test_item - 16 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 16 Aug 2023

I have tested this item ✅ successfully on 27b3efd

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41236.

avatar HLeithner HLeithner - change - 22 Aug 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-22 09:40:14
Closed_By ⇒ HLeithner
Labels Added: Feature PR-5.0-dev
avatar HLeithner HLeithner - close - 22 Aug 2023
avatar HLeithner HLeithner - merge - 22 Aug 2023
avatar HLeithner
HLeithner - comment - 22 Aug 2023

thanks

Add a Comment

Login with GitHub to post a comment