Joomla! Issue Tracker | Joomla! CMS #41226 - [5.0][Events] Content event classes

Feature PR-5.0-dev

Fixed in Code Base
21 Aug 2023
Medium
Build: 5.0-dev
# 41226
Diff
Fedik:content-events

Pending

User tests: Successful: Unsuccessful:

592056f 25 Jul 2023

ContentPrepareEvent

1995a33 25 Jul 2023

AfterTitle, BeforeDisplay, AfterDisplay

ede41c3 25 Jul 2023

Fix category params

Fedik - open - 25 Jul 2023

joomla-cms-bot - change - 25 Jul 2023

Category

⇒

Front End com_content Libraries Plugins

Fedik - change - 25 Jul 2023

Status

New

⇒

Pending

36d8057 25 Jul 2023

phpcs

Fedik - change - 25 Jul 2023

Labels

Added: PR-5.0-dev

276d860 25 Jul 2023

PrepareForm

c070269 25 Jul 2023

PrepareForm

7348762 25 Jul 2023

PrepareForm

63f1b96 25 Jul 2023

PrepareForm

416b885 25 Jul 2023

ContentPrepareData

Fedik - change - 25 Jul 2023

The description was changed

Fedik - edited - 25 Jul 2023

Fedik - change - 25 Jul 2023

The description was changed

Fedik - edited - 25 Jul 2023

5acdf15 25 Jul 2023

ContentNormaliseRequestData

joomla-cms-bot - change - 25 Jul 2023

Category

Front End com_content Libraries Plugins

⇒

Administration Front End com_content com_users Libraries Plugins

Fedik - change - 25 Jul 2023

Labels

Added: Feature

Fedik - change - 25 Jul 2023

The description was changed

Fedik - edited - 25 Jul 2023

HLeithner - comment - 25 Jul 2023

thanks for your work, you are doing a great job

ea220f3 26 Jul 2023

Params b/c compatibility

Fedik - change - 26 Jul 2023

The description was changed

Fedik - edited - 26 Jul 2023

876badf 26 Jul 2023

ContentBeforeSaveEvent

fd7f9a9 26 Jul 2023

ContentAfterSave

3d7bb4f 26 Jul 2023

Fixes for ContentBeforeSave

8feb26f 26 Jul 2023

ContentSaveEvent

93d6c61 26 Jul 2023

ContentDeleteEvent

de10615 26 Jul 2023

ChangeStateEvent

c888f2e 26 Jul 2023

BeforeValidateData

e46283c 26 Jul 2023

Fix Data referencing

joomla-cms-bot - change - 26 Jul 2023

Category

Front End com_content Libraries Plugins Administration com_users

⇒

Administration Front End com_content com_users Libraries

Fedik - change - 26 Jul 2023

The description was changed

Fedik - edited - 26 Jul 2023

Fedik - change - 26 Jul 2023

The description was changed

Fedik - edited - 26 Jul 2023

8696272 26 Jul 2023

Fix params

dcc7054 26 Jul 2023

Re-arange

7b536b2 26 Jul 2023

Re-arange

19f9a2b 26 Jul 2023

Descriptions with example

c0596ab 26 Jul 2023

Descriptions with example

4e67381 26 Jul 2023

Plugin system/fields partial

aef153b 27 Jul 2023

Proxy interface, ArrayProxy class

1e477e3 27 Jul 2023

ObjectProxy class

1eecbc7 27 Jul 2023

Iterating own iterator

e17e974 27 Jul 2023

Cleanup

b317289 27 Jul 2023

Proxy Test

Fedik - comment - 27 Jul 2023

I have no idea why test fails on installation, cypress gives no info.
Localy it works.

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users

⇒

Unit Tests Administration Front End com_content com_users Libraries

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users Unit Tests

⇒

Administration Front End com_content com_users JavaScript Libraries

Fedik - change - 28 Jul 2023

Labels

Added: ?

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users JavaScript

⇒

Administration Front End com_content com_users JavaScript Installation Libraries

Fedik - change - 28 Jul 2023

Labels

Removed: ?

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users JavaScript Installation

⇒

Administration com_config Front End com_content com_users JavaScript Libraries

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users JavaScript com_config

⇒

Administration Front End com_content com_users JavaScript Libraries

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users JavaScript

⇒

Administration com_config Front End com_content com_users JavaScript Libraries

joomla-cms-bot - change - 28 Jul 2023

Category

Front End com_content Libraries Administration com_users JavaScript com_config

⇒

Administration Front End com_content com_users Libraries

joomla-cms-bot - change - 29 Jul 2023

Category

Front End com_content Libraries Administration com_users

⇒

Unit Tests Administration Front End com_content com_users JavaScript Libraries

Fedik - change - 29 Jul 2023

Labels

Added: ?

joomla-cms-bot - change - 29 Jul 2023

Category

Front End com_content Libraries Administration com_users Unit Tests JavaScript

⇒

Administration Front End com_content com_users JavaScript Libraries

Fedik - change - 29 Jul 2023

Labels

Removed: ?

Fedik - comment - 29 Jul 2023

Okay, the error comes from schemaorg plugins, ~~this has to be fixed separately~~ .

joomla-cms-bot - change - 29 Jul 2023

Category

Front End com_content Libraries Administration com_users JavaScript

⇒

Administration Front End com_content com_users Libraries

Fedik - change - 30 Jul 2023

The description was changed

Fedik - edited - 30 Jul 2023

Fedik - comment - 30 Jul 2023

I think it is ready for review and testing

Fedik - comment - 1 Aug 2023

~~I made a PR to 4.4-dev branch to cover $event->getArgument(0) #41298~~

Fedik - change - 5 Aug 2023

The description was changed

Fedik - edited - 5 Aug 2023

Fedik - change - 5 Aug 2023

The description was changed

Fedik - edited - 5 Aug 2023

joomla-cms-bot - change - 5 Aug 2023

Category

Front End com_content Libraries Administration com_users

⇒

Administration com_categories Front End com_content com_users Libraries

Fedik - change - 5 Aug 2023

The description was changed

Fedik - edited - 5 Aug 2023

Fedik - change - 5 Aug 2023

Title

…

[5.0] Content event classes

[5.0][Events] Content event classes

Fedik - edited - 5 Aug 2023

bayareajenn - test_item - 11 Aug 2023 - Tested unsuccessfully

bayareajenn - comment - 11 Aug 2023

I have tested this item ? unsuccessfully on b317289

I tested this after a failed J4 to J5 test that Benjamin thought this PR might help with.

I tested in two server environments.

Server environment 1
I used Patchtester 4.2.2 in J5, applied the patch. Patchtester broke. Manage Extensions broke. Reverting the patch in the db did not resolve the issue.
Error: 0 Cannot set the argument result of the immutable event onContentPrepareForm.
Disabling com_patchtester in the db did not resolve Manage Extensions being broken with the same error as above.

Server environment 2
It wouldn't apply the patch to begin with. Error said:
You have not entered your GitHub API token in the Options. This will limit you to only 60 requests to the GitHub API per hour. Configuring authentication via an API token will allow 5,000 requests per hour.
Could not connect to GitHub: API rate limit exceeded for 72.249.30.219. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

I added my GitHub API token and then applied the patch. In this environment, the entire backend is broken, not just Patchtester. Error says 0 Call to undefined method Joomla\Plugin\System\Schemaorg\Extension\Schemaorg::setUserFactory()

Eek!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41226.}

HLeithner - comment - 14 Aug 2023

@Fedik can you fix the cs please

HLeithner - comment - 14 Aug 2023

with current 5.0 it works, with this pr there is a problem

Fedik - comment - 14 Aug 2023

That sounds like $form is missing in patchtester layout, hmhm

Fedik - comment - 14 Aug 2023

Any idea why this is hidden?

joomla-cms/libraries/src/MVC/Model/ListModel.php

Lines 430 to 433 in 7ec953a

    
               // Get the form. 
        
               return $this->loadForm($this->context . '.filter', $this->filterFormName, ['control' => '', 'load_data' => $loadData]); 
        
           } catch (\RuntimeException $e) { 
        
           }

The error is because the ListModel implements DispatcherAwareInterface, but no one actually set a dispatcher for this legacy component.

In PR it:

joomla-cms/libraries/src/MVC/Model/FormBehaviorTrait.php

Lines 188 to 192 in 2d86862

    
           if ($this instanceof DispatcherAwareInterface) { 
        
               $dispatcher = $this->getDispatcher(); 
        
           } else { 
        
               $dispatcher = Factory::getApplication()->getDispatcher(); 
        
           }

Fedik - comment - 14 Aug 2023

I will update to:

try {
  $dispatcher = $this->getDispatcher();
} catch (\UnexpectedValueException $e) {
  $dispatcher = Factory::getApplication()->getDispatcher();
}

Need to check all places.

Fedik - comment - 14 Aug 2023

Should be good now

Fedik - comment - 14 Aug 2023

Do not merge it for now,
I will look to set a default Dispatcher in BaseDatabaseModel::__constructor

joomla-cms/libraries/src/MVC/Model/BaseDatabaseModel.php

Line 85 in eda2c2c

public function __construct($config = [], MVCFactoryInterface $factory = null)

Fedik - comment - 15 Aug 2023

After the #41371 PR will be merged, it should work fine

HLeithner - comment - 16 Aug 2023

this PR should work now since the fix has been upmerged from 4.4 to 5.0 and merged into this pr

Fedik - change - 17 Aug 2023

The description was changed

Fedik - edited - 17 Aug 2023

Fedik - change - 17 Aug 2023

The description was changed

Fedik - edited - 17 Aug 2023

Fedik - comment - 17 Aug 2023

Okay, now it ready for test again.
Also, I have added a missed event onContentCleanCache

joomla-cms-bot - change - 21 Aug 2023

Category

Front End com_content Libraries Administration com_users com_categories

⇒

Front End com_content Libraries

HLeithner - change - 21 Aug 2023

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2023-08-21 07:46:26
Closed_By		⇒	HLeithner

HLeithner - close - 21 Aug 2023

HLeithner - merge - 21 Aug 2023

HLeithner - comment - 21 Aug 2023

thanks

Fedik - change - 22 Aug 2023

The description was changed

Fedik - edited - 22 Aug 2023

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#41226] - [5.0][Events] Content event classes

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Add a Comment

	// Get the form.
	return $this->loadForm($this->context . '.filter', $this->filterFormName, ['control' => '', 'load_data' => $loadData]);
	} catch (\RuntimeException $e) {
	}

	if ($this instanceof DispatcherAwareInterface) {
	$dispatcher = $this->getDispatcher();
	} else {
	$dispatcher = Factory::getApplication()->getDispatcher();
	}