Feeling Lucky
PR-5.0-dev
[#41220] - [5.0] com_finder new toolbar api
- Closed
- 26 Jul 2023
- Medium
- Build: 5.0-dev
- # 41220
- Diff
- heelc29:5.0/finder/toolbar-api
User tests: Successful: Unsuccessful:
Summary of Changes
Apply changes from #39537 for new debugging features (#36753)
Testing Instructions
check button still work and are rendered correctly for LTR and RTL
Actual result BEFORE applying this Pull Request
works
Expected result AFTER applying this Pull Request
works
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Status | New | ⇒ | Pending |
heelc29
- comment
- 25 Jul 2023
so it doesn't makes it better
Ok, but then we have only to replace how we get the toolbar instance like in all the other components ...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-26 16:35:55 |
| Closed_By | ⇒ | heelc29 | |
| Labels |
Added:
PR-5.0-dev
|
||
actually
Toolbar::getInstance()is deprecated, so it doesn't makes it better. I'm planing to move the instance to the document but didn't had the time yet to implement it...