Joomla! Issue Tracker | Joomla! CMS #41202 - [5.0] b/c plugin - Load class aliases earlier and move es5 assets

Language Change NPM Resource Changed PR-5.0-dev

Fixed in Code Base
22 Jul 2023
Medium
Build: 5.0-dev
# 41202
Diff
HLeithner:5/bc/plugin-new

Pending

User tests: Successful: Unsuccessful:

HLeithner
21 Jul 2023

This PR moves the class alias loading to the constructor function of the plugin to load the alias at the earliest possible execution point.

Additional this PR moves all es5 assets from all joomla.asset.json into the es5.asset.json and make loading them optional.

Summary of Changes

Move class aliasing to the constructor
Move es5 webassets to the plugin

Testing Instructions

Full CMS with and without plugin active

Actual result BEFORE applying this Pull Request

Should work

Expected result AFTER applying this Pull Request

Should still work

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

fb00bd3 21 Jul 2023

Move classmap import to the plugin constructor

9120102 21 Jul 2023

Merge branch '5.0-dev' into 5/bc/plugin-new

53ebd38 21 Jul 2023

Move es5 assets to b/c plugin

joomla-cms-bot - change - 21 Jul 2023

Category

SQL Administration com_admin Postgresql Language & Strings Repository NPM Change

⇒

SQL Administration com_admin Postgresql Language & Strings Templates (admin) Repository NPM Change

5d38610 21 Jul 2023

Move missing es5 assets to b/c plugin

HLeithner - comment - 21 Jul 2023

I see that there are still es5 references in administrator\templates\atum\joomla.asset.json build\media_source\com_joomlaupdate\joomla.asset.json build\media_source\plg_system_jooa11y\joomla.asset.json

Thanks, don't know why my initial search didn't found the 3 assets.... in the build folder... the template I didn't checked tbh

brianteeman - comment - 21 Jul 2023

I just grepped for es5 in all joomla.asset.json files

brianteeman - comment - 21 Jul 2023

Does this need changing as well

joomla-cms/build/build-modules-js/settings.json

Lines 77 to 87 in e7e1fb4

    
           "name": "bootstrap.es5", 
        
           "type": "script", 
        
           "deprecated": true, 
        
           "uri": "", 
        
           "dependencies": [ 
        
             "core" 
        
           ], 
        
           "attributes": { 
        
             "nomodule": true, 
        
             "defer": true 
        
           }

HLeithner - comment - 21 Jul 2023

Does this need changing as well

joomla-cms/build/build-modules-js/settings.json

Lines 77 to 87 in e7e1fb4

"name": "bootstrap.es5",

"type": "script",

"deprecated": true,

"uri": "",

"dependencies": [

"core"

],

"attributes": {

"nomodule": true,

"defer": true

}