[#41165] - [5.x] CacheController
- Closed
- 17 Jul 2023
- Medium
- Build: 5.0-dev
- # 41165
- Diff
- brianteeman:CacheController
User tests: Successful: Unsuccessful:
Summary of Changes
This is based on a code review and I am going to have to rely on better coders to confirm my assumption and the proposed fix.
From my reading of the code this change is needed in the CacheController for J5 as without the change it is relying on the classmap which is not enabled by default and core should not require.
The code is cloned from libraries\src\Cache\CacheStorage.php so it should be correct
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
It didnt produce any errors (afaict) I just observed the difference in the code. IfI understand it correctly before this PR the code was checking the old style first and falling back to the current style and this reverses that just as it was already done in many place.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-17 12:03:14 |
| Closed_By | ⇒ | HLeithner |
I understand, but in this case we already checking the new one in the try-block and fall back if this fails. so trying again the new namespace variant would be reduntant, I'm closing this because this function is planned to be removed with 6.0 in which version also the old prefixed classnames go away.
thanks anyway for looking into this.
so trying again the new namespace variant would be reduntant
I am confused. This is changing the order so its new and then fallback to old.
Did this error occur? Because the cachecontrollerfactory does exactly the same