[#41153] - [4.3] The arrow-up icon of the Back-to-top Link should be visible on hovering.
- Closed
- 14 Sep 2023
- Medium
- Build: 4.3-dev
- # 41153
- Diff
- sandewt:patch-6
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The arrow-up icon of the Back-to-top Link should be visible on hovering.
And in addition, the color of the button must then be blue.
Related to the Button text color issue #40435, that caused this problem.
Testing Instructions
Build npm ci.
Enable the Back-to-top Link button in Templates: Edit Style.
Hover on the Back-to-top button in the fontend of the site.
Code review
Actual result BEFORE applying this Pull Request
The arrow-up icon is NOT visible on hovering on the button.
Expected result AFTER applying this Pull Request
The arrow-up icon is visible on hovering on the button.
Link
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
I cannot replicate the problem on j43
Clear the browser cache.
How will clearing the browser cache have any impact on the site BEFORE applying this PR?
I have not applied the PR because I can not replicate the reported problem
How will clearing the browser cache have any impact on the site BEFORE applying this PR?
What is the result if you clear the browser history?
it is the same of course
it is the same of course
I should have known better.
System information:
Windows 11, Firefox, MS Edge and Google Chrome.
Hello,
I had a similar issue on my website after upgrading to 4.3.3 and had to roll-back to 4.3.2 because it broke the hover colors not only of the "Back-to-top Link" but of some other components as well. Took me a while to understand that was not me but the upgrade. Restored from backup to 4.3.2 and all was fixed. Simulated on my laptop and yes that was the culprit -> 4.3.3..
Any news when it will be fixed? Any workaround meanwhile?..
Thanks a lot!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41153.
The main issue comes from the fact that many button-like elements are actually not using the .btn class and that is where the confusion starts... So any 'a' element, styled as a button, but not having the .btn class will have a problem
See #40435 (comment)
Issue confirmed (Back to top Link) but NPM Package is not available (404)
Issue confirmed (Back to top Link) but NPM Package is not available (404)
You can still download the package; or in the command-line interface run the npm ci command.
Anyway, I prefer the overall solution, which I have proposed here: #40435 (comment)
However, I am still waiting for a response(s).
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-14 11:48:08 |
| Closed_By | ⇒ | sandewt | |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
I cannot replicate the problem on j43 or j5