[#41138] - Fix allowed chars in mailer subject
- Fixed in Code Base
- 28 Aug 2023
- Medium
- Build: 4.3-dev
- # 41138
- Diff
- Denitz:MailHelper_cleanSubject
User tests: Successful: Unsuccessful:
Pull Request for Issues #31768, #40571.
Summary of Changes
Currently, email subject is validated as email address, hence it's impossible to send an email with a subject like Test email for test@test.com {test}
The problem is that email subject is incorrectly validated as email address since 2006, see dec8927#diff-89c219c58287d02dd7de50360cf6656e7ab96bfd20ef065ef54db235ff12dea4R127
Current MailHelper::cleanSubject() was never used, we can use it.
Testing Instructions
Send an email with subject Test email for test@test.com {test}
Actual result BEFORE applying this Pull Request
See error
Expected result AFTER applying this Pull Request
No errors
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
bug
PR-4.3-dev
|
||
I have tested this item ✅ successfully on e8b28cf
Jooma 4.3 dev with PHP 8.1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138.
I have an error sending a message with or without special characters in the subject after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138.
I have tested this item ✅ successfully on e8b28cf
Tested on localhost Joomla 4.3.4 @pbf 2023
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138.
@richard67 test Joomla 5.0 Beta 1 - php 8.1.18 - 10.5.21 MariaDB.
@richard67 test Joomla 5.0 Beta 1 - php 8.1.18 - 10.5.21 MariaDB.
@Magnytu2 This pull request here is for the 4.3-dev branch, sou you cannot test it on a 5.0-beta1-dev.
| Labels |
Added:
?
PBF
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-28 20:03:13 |
| Closed_By | ⇒ | obuisard |
I have tested this item ✅ successfully on e8b28cf
Tested this using mass mailer function and send an e-mail. after patch mail was sent succesfully. before it did not send e-mail.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41138.