? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
10 Jul 2023

Summary of Changes

Validation of joomla.asset.json (JSON) is broken since J4.1 #35998 (child templates)

str_ends_with should covered by polyfill:

"symfony/polyfill-php80": "^1.16",

Testing Instructions

try to edit joomla.asset.json and save with an invalid json (eg. double comma)

Actual result BEFORE applying this Pull Request

file saved
image

site broken (here frontend cassiopeia)
image

Expected result AFTER applying this Pull Request

file not saved
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2023
Category Administration com_templates
avatar heelc29 heelc29 - open - 10 Jul 2023
avatar heelc29 heelc29 - change - 10 Jul 2023
Status New Pending
avatar heelc29 heelc29 - change - 12 Jul 2023
Labels Added: bug PR-4.3-dev
avatar Quy Quy - test_item - 12 Jul 2023 - Tested successfully
avatar Quy
Quy - comment - 12 Jul 2023

I have tested this item successfully on 5bf1e08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135.

avatar alikon alikon - test_item - 13 Jul 2023 - Tested successfully
avatar alikon
alikon - comment - 13 Jul 2023

I have tested this item successfully on 5bf1e08


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135.

avatar alikon alikon - change - 13 Jul 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 13 Jul 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41135.

avatar obuisard obuisard - change - 14 Jul 2023
Labels Added: ?
avatar obuisard obuisard - close - 14 Jul 2023
avatar obuisard obuisard - merge - 14 Jul 2023
avatar obuisard obuisard - change - 14 Jul 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-14 20:26:40
Closed_By obuisard
avatar obuisard
obuisard - comment - 14 Jul 2023

Thank you @heelc29 for the PR!

Add a Comment

Login with GitHub to post a comment