[#41133] - [5.x] Corrected headings ordering in contact
- Fixed in Code Base
- 26 Aug 2023
- Medium
- Build: 5.0-dev
- # 41133
- Diff
- drmenzelit:contact-heading
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
If "Show Page Heading" in a single contact is set to "Hide", you will get errors with the accessibility checker, because the headings are skipping a level.
Summary of Changes
Added a new htag2 variable to replace the hard-coded <h3> elements.
Testing Instructions
Create a contact and a menu item for it.
Activate the Accessibility Checker Plugin in the frontend and check the output with and without Page Heading.
Actual result BEFORE applying this Pull Request
Without Page Heading
Expected result AFTER applying this Pull Request
With Page Heading
Without Page Heading
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
Links should be H2.
Before PR:
After PR:
Maybe rewrite the following:
<<?php echo $htag2; ?>><?php echo Text::_('COM_CONTACT_DETAILS'); ?></<?php echo $htag2; ?>>
to the following for easier code reading??:
<?php echo '<' . $htag2 . '>' . Text::_('COM_CONTACT_DETAILS') . '</' . $htag2 . '>'; ?>
| Labels |
Added:
a11y
PR-5.0-dev
|
||
Under Contact Display Options, set Name to Hide.
Hmm... I will have to check the logic again ...
I hope I got all combinations correctly:
Show page heading & Show name -> Page Heading = h1 | Name = h2 | Others = h3
Show page heading & Hide name -> Page Heading = h1 | Others = h2
Hide page heading & Show name -> Name = h1 | Others = h2
Hide page heading & Hide name -> Others = h2 and you get an error "missing h1", that is the same we have in a category blog
Hide page heading & Hide name -> Others = h2 and you get an error "missing h1", that is the same we have in a category blog
Beyond the scope of this PR? If yes, I will mark it successful.
Beyond the scope of this PR? If yes, I will mark it successful.
Yes, and I don't know, if there is a solution for that.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41133.
But if i have 3 Authors and i enable the Page Heading AFTER applying this Pull Request, now i have 3 pages with the same H1, and this is wrong.
For me Page Heading in this case is only a visual element, nothing to do with the semantic of page, in an author's page the H1 must be always the "The Author" (that is unique)
You have the same behaviour without the PR, because the page heading comes from the menu. And you have the same behaviour on a blog layout. I'm not saying it is correct or not.
I have tested this item ✅ successfully on 26ff6f7
On Joomla 5.0 with PHP 8.1.22
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41133.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-26 13:51:09 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested this item✅ successfully on 3ddca9a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41133.