Feeling Lucky
No Code Attached Yet
[#41123] - [4.x] - No Seperators for menu items in custom components
- Closed
- 2 Jan 2024
- Medium
- Build: 4.3
- # 41123
Steps to reproduce the issue
No possibility to create divider items in custom component menu.
Create a new Custom component and try to add a menu item of type seperator
like <menu type="seperator"></menu>. There will no divider be rendered / an error is thrown on installation. First issue is that "Menus items are hardcoded to have "component" type during component installation." (see Sharky's comment here: Link
Expected result
Using '
' (or similar) should be a valid option for developers to add dividers into their components menu in the sidebar that got rendered like in the com_content menu for example:<li class="divider item-level-3" role="presentation"><span></span></li>Actual result
- Error gets thrown if a menu item got created without title / content
- There is no way to create divider into the submenus of a component
System information (as much as possible)
- Joomla 4.3.2
- PHP 8.2
- MAMP Installation Apache
Additional comments
If editing the HTML on Page and adding the HTML Snipped above into the page its rendered correctly so no CSS changes are required only a way to create / parse the "seperator" when used in the component.xml >> menu >> submenu XML structure.
Votes
# of Users Experiencing Issue
1/1
Average Importance Score
4.00
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
richard67
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-02 10:46:02 |
| Closed_By | ⇒ | richard67 |
The fix to this issue is to update line #1072 of
..\libraries\src\Installer\Adapter\ComponentAdapter.phpby replacing$data['type'] = 'component';with this line
$data['type'] = ((string) $child->attributes()->type) ?: 'component';This will result in the
typefield of#__menubeing updated with the value specified in a 'new' attribute of the<menu>element calledtype.For example you would be able to specify a type of separator in the manifest.xml
<menu type="separator">----</menu>The default is to use the current value of 'component' thus there should be no issues created for existing or new entries if
typeis not specified.The dashes/hyphens are not used but there needs to be at least one non-blank character to avoid an error being issued for a missing title as per normal processing.