PHP 8.x PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
6 Jul 2023

Pull Request for Issue # .

Summary of Changes

declare variables

Testing Instructions

set error report to maximum
go to Joomla Updatde
and / or php cli/joomla.php update:extensions:check

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

no more deprecations

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2023
Category Libraries
avatar alikon alikon - open - 6 Jul 2023
avatar alikon alikon - change - 6 Jul 2023
Status New Pending
avatar alikon alikon - change - 6 Jul 2023
Labels Added: PR-5.0-dev
avatar alikon alikon - change - 6 Jul 2023
The description was changed
avatar alikon alikon - edited - 6 Jul 2023
avatar alikon alikon - change - 6 Jul 2023
Labels Added: PHP 8.x
avatar alikon alikon - change - 6 Jul 2023
The description was changed
avatar alikon alikon - edited - 6 Jul 2023
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2023
Category Libraries Administration com_admin Libraries
avatar HLeithner
HLeithner - comment - 1 Aug 2023

doesn't this problem also exists in 4.3 and 4.4?

avatar alikon
alikon - comment - 1 Aug 2023

i didn't check, discovered when #41117

avatar HLeithner
HLeithner - comment - 1 Aug 2023

can you please check and rebase for at least 4.4

avatar alikon
alikon - comment - 6 Aug 2023

wrong rebase, i'll switch it back to 5

avatar heelc29
heelc29 - comment - 6 Aug 2023

doesn't this problem also exists in 4.3 and 4.4?

I think it's only 5.x ...

#40999

avatar HLeithner
HLeithner - comment - 13 Aug 2023

@alikon can I merge this or do you have further plans?

avatar alikon
alikon - comment - 13 Aug 2023

yes please, as long as i'll discover some more i'll do another pr

avatar HLeithner HLeithner - change - 13 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-13 07:58:01
Closed_By HLeithner
avatar HLeithner HLeithner - close - 13 Aug 2023
avatar HLeithner HLeithner - merge - 13 Aug 2023
avatar HLeithner
HLeithner - comment - 13 Aug 2023

thanks, I tested it and worked for me.

Add a Comment

Login with GitHub to post a comment