[#41111] - [4.4] Update FtpClient.php
- Fixed in Code Base
- 21 Aug 2023
- Medium
- Build: 4.3-dev
- # 41111
- Diff
- stell:patch-1
User tests: Successful: Unsuccessful:
PHP 8.1
Pull Request for Issue #40438.
Summary of Changes
Existing code that relied on is_resource function now needs to account for the new FTP\Connection class objects in PHP 8.1.
Testing Instructions
see #40438.
Actual result BEFORE applying this Pull Request
fail
Expected result AFTER applying this Pull Request
works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
@richard67 Checking boolean works for FTP Buffer (< 8.1) and FTP\Connection(> 8.0) as far i can see.
It' something for j4.4 but please check if is_resource or object and instance of the ftp class.
| Title |
|
||||||
I have tested this item ✅ successfully on 0d75fae
Tested on PHP 8.2 and 7.4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41111.
| Labels |
Added:
PR-4.4-dev
Removed: PR-4.3-dev |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-21 14:36:22 |
| Closed_By | ⇒ | MacJoom |
@stell Will this still work on PHP versions older than 8.1? If not, the PR cannot be used for 4.3 or 4.4 and has to be made for 5.0, i.e. the base branch needs to be changed to 5.0-dev. With Joomla 4.3 and 4.4 we still have to support older PHP versions, with Joomla 5 the minimum required PHP version will be 8.1.