?
avatar chrisdavenport
chrisdavenport
14 Aug 2014

Steps to reproduce the issue

  1. Make sure you have one or more distinctive words entered in the Banned Subject and Banned Text fields of a contact.
  2. On the front-end, go to the form for the contact and try to send a message with the subject and/or message containing one of the banned words.

Expected result

An error message should be shown to say that a field was in error. No contact email should be sent.

Actual result

No error message is shown and the contact email is sent.

System information (as much as possible)

Joomla 2.5.24

Additional comments

Fix is trivial. I'll submit a PR shortly.

avatar chrisdavenport chrisdavenport - open - 14 Aug 2014
avatar brianteeman
brianteeman - comment - 14 Aug 2014

There was a commit not too long ago for this iirc #3068

avatar chrisdavenport
chrisdavenport - comment - 14 Aug 2014

JString::stristr($item, $value) is the wrong way around. It should be JString::stristr($value, $item). The first argument is the haystack, the second is the needle.

avatar chrisdavenport chrisdavenport - reference | - 14 Aug 14
avatar chrisdavenport
chrisdavenport - comment - 14 Aug 2014

Pull request: #4113

avatar chrisdavenport
chrisdavenport - comment - 15 Aug 2014

Done. Well spotted @zero-24

avatar chrisdavenport chrisdavenport - reference | - 16 Aug 14
avatar infograf768 infograf768 - reference | - 20 Aug 14
avatar zero-24
zero-24 - comment - 21 Aug 2014

This is merged: #4120 so we can close here.

avatar zero-24 zero-24 - close - 21 Aug 2014
avatar Bakual
Bakual - comment - 21 Aug 2014

Closing

avatar Bakual Bakual - change - 21 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-21 06:50:07
avatar Bakual Bakual - close - 21 Aug 2014
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment