Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41105] - Hard coded colors instead of css variables

No Code Attached Yet
avatar hans2103
hans2103
3 Jul 2023

Media/templates/site/cassiopeia/scss/vendor/bootstrap/_buttons.scss

what is the use of hard coded colors when we work with css variables instead?

joomla-cms/build/media_source/templates/site/cassiopeia/scss/vendor/bootstrap/_buttons.scss

Lines 17 to 39 in 3a44db8

color: $gray-800;
background-color: $white;
border-color: $gray-400;
&:hover,
&:focus {
color: $gray-800;
background-color: $gray-100;
}
}
.article-info .association,
.cat-list-association {
.btn-secondary {
font-weight: 700;
color: $white;
background-color: $gray-600;
border-color: $gray-400;
&:hover,
&:focus {
color: $white;
background-color: $gray-800;

avatar hans2103 hans2103 - open - 3 Jul 2023
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Jul 2023
avatar brianteeman
brianteeman - comment - 3 Jul 2023

are you referring to using $white instead of var(--something) ??

avatar hans2103
hans2103 - comment - 3 Jul 2023

See screenshot below where .btn-secondary has both css variables as scss variables.
Scherm­afbeelding 2023-07-03 om 10 42 11

avatar richard67 richard67 - change - 13 Dec 2023
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-12-13 22:36:43
Closed_By ⇒ richard67
avatar richard67 richard67 - close - 13 Dec 2023
avatar richard67
richard67 - comment - 13 Dec 2023

Closing as having a pull request.

Add a Comment

Login with GitHub to post a comment