Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41092] - [5.0] Move from static Text access to the text function of the plugin

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
30 Jun 2023

Summary of Changes

The $this->text() function should be used in plugin template files to translate strings. This eliminates the static use of Text::_. When template files start to use functionality from the current context it will allow them to be reusable.

Testing Instructions

  • Create an url custom field
  • Open TinyMCE by editing an article
  • Check if the strings in the editor buttons are translated

Actual result BEFORE applying this Pull Request

All strings are translated.

Expected result AFTER applying this Pull Request

All strings are translated.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jun 2023
Category ⇒ Libraries Front End Plugins
avatar laoneo laoneo - open - 30 Jun 2023
avatar laoneo laoneo - change - 30 Jun 2023
Status New ⇒ Pending
avatar laoneo laoneo - change - 30 Jun 2023
Title
…
Move from static Text access to the text function of the plugin
[5.0] Move from static Text access to the text function of the plugin
avatar laoneo laoneo - edited - 30 Jun 2023
avatar richard67
richard67 - comment - 30 Jun 2023

@laoneo System tests are failing, and I think it could be related to this PR.

avatar laoneo laoneo - change - 1 Jul 2023
Labels Added: PR-5.0-dev
avatar laoneo
laoneo - comment - 17 Aug 2023

Closing in favor of #41384.

avatar laoneo laoneo - close - 17 Aug 2023
avatar laoneo laoneo - change - 17 Aug 2023
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-17 15:17:03
Closed_By ⇒ laoneo

Add a Comment

Login with GitHub to post a comment