Feeling Lucky
?
PR-4.4-dev
[#41075] - [4.4] fix namespace for mailer factory unit test
- Fixed in Code Base
- 28 Jun 2023
- Medium
- Build: 4.4-dev
- # 41075
- Diff
- heelc29:4.4/tests/unit/mailerfactory
User tests: Successful: Unsuccessful:
Summary of Changes
namespace corrected
Testing Instructions
Run unit tests
Actual result BEFORE applying this Pull Request
Class Joomla\Tests\Unit\Libraries\Cms\Layout\MailFactoryTest located in
tests\Unit\Libraries\Cms\Mail\MailFactoryTest.php does not comply with psr-4 autoloading standard.
Skipping.
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Status | New | ⇒ | Pending |
richard67
- comment
- 27 Jun 2023
Hmm maybe the file should be renamed to “MailerFactoryTest.php” so it fits to the class name? As far as I know the file name doesn’t matter for the tests working, but they should fit somehow to the class name. @laoneo What do you think?
Sorry, all fine. Was trapped by shortened path on small mobile screen.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-28 00:13:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
PR-4.4-dev
|
||
wilsonge
- comment
- 28 Jun 2023
Thanks! Merging with one good test as it's so obviously correct and drone approves
I have tested this item ✅ successfully on 98f46e7
Can be verified in these logs:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41075.