PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Jun 2023

Summary of Changes

Adds a module position to the error.php page of system template so that you can customise the 404 page without having to change language strings or asking the user to modify the error.php (which they will lose on update)

This is fully backwards compatible as the existing error page text is displayed if there is no module. If debug is enabled then the debug information is still displayed

In theory the error.php is used by joomla for all error codes so this PR is able to display a specific module for each error code.

This system error.php is only displayed if the site template does not have its own error.php

Testing Instructions

Apply the PR
Create a new module (custom html is probably the most useful) and publish in the new position error-404
Rename/delete the cassiopeia error.php file so that this system file will be used
Go to a fake page on your site and you will see the 404 page with your new module
Unpublish the module and repeat and you will see the original 404 page with the language strings

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jun 2023
Category Front End Templates (site)
avatar brianteeman brianteeman - open - 26 Jun 2023
avatar brianteeman brianteeman - change - 26 Jun 2023
Status New Pending
avatar HLeithner HLeithner - close - 26 Jun 2023
avatar HLeithner HLeithner - merge - 26 Jun 2023
avatar HLeithner HLeithner - change - 26 Jun 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-26 08:24:56
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 26 Jun 2023

thanks

avatar brianteeman
brianteeman - comment - 26 Jun 2023

thanks

avatar HLeithner
HLeithner - comment - 26 Jun 2023

cs bokes the ci now in addition to the media manager pr...

avatar heelc29
heelc29 - comment - 27 Jun 2023

@HLeithner Could you add the Joomla 5.0 milestone to this PR? This also concerns some other PRs.

avatar heelc29
heelc29 - comment - 29 Jun 2023

@HLeithner Here is a link to all other PRs (54) merged into 5.0-dev without milestone:
https://github.com/joomla/joomla-cms/pulls?page=3&q=is%3Amerged+is%3Apr+label%3APR-5.0-dev+no%3Amilestone

Add a Comment

Login with GitHub to post a comment