Feature Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar sdwjoomla
sdwjoomla
25 Jun 2023

Updated the step descriptions for How to Create Articles to provide more information for new users.

Pull Request for Issue # .

Summary of Changes

  • Updated How to Create Articles steps in the com_guidedtours.sys.ini file
  • Added SQL files to change the position of the category step with language string title COM_GUIDEDTOURS_TOUR_ARTICLES_STEP_CATEGORY_TITLE
  • Updated installation/extensions.sql file

Testing Instructions

Using a Joomla 5.0 instance, click Take a Tour > How to Create Articles?
2023-05-14_13-39-41

Actual result BEFORE applying this Pull Request

Step 1: How to create articles
2023-05-14_13-44-28

Step 2: Select the 'New' Button
2023-05-14_13-45-16

Step 3: Add a title for the article
2023-05-14_13-46-20

Step 4: Enter an alias
2023-05-14_13-47-04

Step 5: Add content
2023-05-14_13-47-49

Step 6: Select the status
2023-05-14_13-48-58

Step 7: Select a category
2023-05-14_13-49-44

Step 8: Toggle featured
2023-05-14_13-50-22

Step 9: Set the access level
2023-05-14_13-51-25

Step 10: Add tags
2023-05-14_13-52-14

Step 11: Add a note
2023-05-14_13-53-05

Step 12: Add a version note
2023-05-14_13-53-50

Step 13: Select 'Save and Close'
2023-05-14_13-54-34

Step 14: Congratulations
2023-05-14_13-55-09

Expected result AFTER applying this Pull Request

Step 1: How to create articles?
2023-06-25_08-50-49

Step 2: Create a New Article
2023-06-25_08-52-42

Step 3: Add a Title for the Article
2023-06-25_08-53-15

Step 4: Generate or Add the Article Alias
2023-06-25_08-53-26

Step 5: Add Your Content
2023-06-25_08-53-55

Step 6: Set the Article Status
2023-06-25_08-54-06

Step 7: Select Article Category
2023-06-25_08-54-38

Step 8: Feature the Article
2023-06-25_08-54-55

Step 9: Set Article Access Level
2023-06-25_08-55-07

Step 10: Add One or More Tags
2023-06-25_08-55-24

Step 11: Add a Note
2023-06-25_08-55-42

Step 12: Add a Version Note
2023-06-25_08-55-50

Step 13: Save and Close
2023-06-25_08-56-09

Step 14: Congratulations!
2023-06-25_08-56-28

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2023
Category SQL Administration com_admin Postgresql Language & Strings
avatar sdwjoomla sdwjoomla - open - 25 Jun 2023
avatar sdwjoomla sdwjoomla - change - 25 Jun 2023
Status New Pending
avatar sdwjoomla sdwjoomla - change - 25 Jun 2023
The description was changed
avatar sdwjoomla sdwjoomla - edited - 25 Jun 2023
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2023
Category SQL Administration com_admin Postgresql Language & Strings SQL Administration com_admin Postgresql Language & Strings Installation
avatar sdwjoomla sdwjoomla - change - 25 Jun 2023
Labels Added: Language Change PR-5.0-dev
avatar sdwjoomla sdwjoomla - change - 25 Jun 2023
The description was changed
avatar sdwjoomla sdwjoomla - edited - 25 Jun 2023
avatar brianteeman
brianteeman - comment - 25 Jun 2023

I am not in favour of this change. It breaks multiple guidelines for the UI. Specifically https://manual.joomla.org/docs/user-interface-text/#notes

avatar sdwjoomla
sdwjoomla - comment - 7 Jul 2023

Thank you @brianteeman for taking a look at the PR. The link provided speaks to "Avoid Over Communications" which does not apply in this case as it falls more within the documentation area. The intended audience would need the extra information that the updated language provides.

avatar brianteeman
brianteeman - comment - 7 Jul 2023

I guess we will have to agree to disagree then. I am a firm believer that the more text there is then the less likely it is that someone will ever read it. Especially the beginner ;)

However you still have lots of issues in the text you have provided. For example you have changed select to click. It is very deliberately select as you cant click on a touch screen or with a screen reader.

avatar brianteeman
brianteeman - comment - 9 Jul 2023

I guess you only tested these changes at a large screen resolution. At 1280x720 for example it no longer works because the text is so long the popup covers the input (or worse posint to the wrong input)

chrome_2023-07-09_16-50-19.mp4
avatar brianteeman brianteeman - test_item - 9 Jul 2023 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 9 Jul 2023

I have tested this item ? unsuccessfully on 5771442


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41046.

avatar sdwjoomla
sdwjoomla - comment - 9 Jul 2023

@brianteeman was done on a laptop. The SQL changes are changes in position to address overlay issues.
Resetting the PR to draft until the language change issues noted by @HLeithner are resolved.

avatar brianteeman
brianteeman - comment - 9 Jul 2023

@brianteeman was done on a laptop. The SQL changes are changes in position to address overlay issues.

that;s why I made the video

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar web54
web54 - comment - 24 Feb 2024

tried and failed :
image
image
and so on ...

avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.0] Guided Tours: How to Create Articles Updated Language
[5.2] Guided Tours: How to Create Articles Updated Language
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar sdwjoomla sdwjoomla - close - 24 Aug 2024
avatar sdwjoomla
sdwjoomla - comment - 24 Aug 2024

Closing PR - will work with the GT team to implement in the future.

avatar sdwjoomla sdwjoomla - change - 24 Aug 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-08-24 13:14:24
Closed_By sdwjoomla
Labels Added: Feature PR-5.2-dev
Removed: PR-5.0-dev

Add a Comment

Login with GitHub to post a comment