Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41044] - [5.0] Remove obsolete use of es5 script from quickicon admin module

? PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
25 Jun 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) removes the $wa->registerAndUseScript call in the quickicon admin module's default template for loading the "quickicon-es5.min.js" script, since that script doesn't exist anymore since PR #39618 has been merged.

Testing Instructions

Code review, and check that the quickicons module still works with option "Show items with count" switched on.

Actual result BEFORE applying this Pull Request

The quickicon admin module's default template contains an obsolete call to $wa->registerAndUseScript for loading the "quickicon-es5.min.js" script.

Expected result AFTER applying this Pull Request

The quickicon admin module's default template doesn't contain an obsolete call to $wa->registerAndUseScript for loading the "quickicon-es5.min.js" script.

The module still works as well as before.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2023
Category ⇒ Modules Administration
avatar richard67 richard67 - open - 25 Jun 2023
avatar richard67 richard67 - change - 25 Jun 2023
Status New ⇒ Pending
avatar Fedik
Fedik - comment - 25 Jun 2023

Looks good, can be tested by review, or just checking that quickicons with option "Show items with count" still works

avatar richard67 richard67 - change - 25 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 25 Jun 2023
avatar richard67 richard67 - change - 25 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 25 Jun 2023
avatar richard67 richard67 - change - 25 Jun 2023
Title
…
[5.0] [WiP] Fix quickicon admin module after removing es5
[5.0] Fix quickicon admin module after removing es5
avatar richard67 richard67 - edited - 25 Jun 2023
avatar richard67 richard67 - change - 25 Jun 2023
Title
…
[5.0] Fix quickicon admin module after removing es5
[5.0] Remove obsolete use of es5 script from quickicon admin module
avatar richard67 richard67 - edited - 25 Jun 2023
avatar Fedik Fedik - test_item - 25 Jun 2023 - Tested successfully
avatar Fedik
Fedik - comment - 25 Jun 2023

I have tested this item ✅ successfully on 9d93b09

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41044.

avatar richard67
richard67 - comment - 25 Jun 2023

Not a release blocker since nothing's really broken, but would be good to have it in the upcoming 5.0.0 Alpha 2.

avatar richard67 richard67 - change - 25 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 25 Jun 2023
avatar dgrammatiko dgrammatiko - test_item - 25 Jun 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 25 Jun 2023

I have tested this item ✅ successfully on 9d93b09

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41044.

avatar dgrammatiko
dgrammatiko - comment - 25 Jun 2023

I have tested this item ✅ successfully on 9d93b09

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41044.

avatar richard67 richard67 - change - 25 Jun 2023
Status Pending ⇒ Ready to Commit
Labels Added: PR-5.0-dev
avatar richard67
richard67 - comment - 25 Jun 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41044.

avatar HLeithner HLeithner - close - 25 Jun 2023
avatar HLeithner HLeithner - merge - 25 Jun 2023
avatar HLeithner HLeithner - change - 25 Jun 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-06-25 13:33:43
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 25 Jun 2023

thanks

Add a Comment

Login with GitHub to post a comment