? Release Blocker bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
25 Jun 2023

Pull Request for Issue # .

Summary of Changes

Fix tinymce highlight plugin after removing es5

Testing Instructions

Run npm install, check tinymce editor

Actual result BEFORE applying this Pull Request

Broken

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

ref #39618

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2023
Category Front End Plugins
avatar Fedik Fedik - open - 25 Jun 2023
avatar Fedik Fedik - change - 25 Jun 2023
Status New Pending
avatar Fedik Fedik - change - 25 Jun 2023
The description was changed
avatar Fedik Fedik - edited - 25 Jun 2023
avatar richard67 richard67 - test_item - 25 Jun 2023 - Tested successfully
avatar richard67
richard67 - comment - 25 Jun 2023

I have tested this item successfully on 662dca3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41042.

avatar richard67
richard67 - comment - 25 Jun 2023

@Fedik I've found another one: #41044 . Could you check if my fix is right?

avatar richard67
richard67 - comment - 25 Jun 2023

I've set the "Release Blocker" label since the TinyMCE is nearly completely broken in 5.0-dev without this fix.

avatar dgrammatiko dgrammatiko - test_item - 25 Jun 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 25 Jun 2023

I have tested this item successfully on 662dca3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41042.

avatar richard67 richard67 - change - 25 Jun 2023
Status Pending Ready to Commit
Labels Added: bug Release Blocker PR-5.0-dev
avatar richard67
richard67 - comment - 25 Jun 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41042.

avatar HLeithner HLeithner - close - 25 Jun 2023
avatar HLeithner HLeithner - merge - 25 Jun 2023
avatar HLeithner HLeithner - change - 25 Jun 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-25 13:35:12
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 25 Jun 2023

thanks

Add a Comment

Login with GitHub to post a comment