? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Jun 2023

We should be using inclusive naming throughout the cms not just in the language strings.

In this specific case it is not being changed as sadly php still uses the term "master value" and here it is used to produce a downloadable text file of phpinfo().

The comment is simply to explain why it has not been changed for future reference

Rationale

https://inclusivenaming.org/word-lists/tier-1/_master/

Test

Code review Only

Documentation

New page will be added to manual.joomla.org shortly

Note

This is part of a series of pull requests that are submitted separately to make reviewing easier

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2023
Category Administration com_admin
avatar brianteeman brianteeman - open - 23 Jun 2023
avatar brianteeman brianteeman - change - 23 Jun 2023
Status New Pending
avatar brianteeman brianteeman - change - 23 Jun 2023
Labels Added: PR-4.3-dev
avatar alikon alikon - test_item - 24 Jun 2023 - Tested successfully
avatar alikon
alikon - comment - 24 Jun 2023

I have tested this item successfully on 033a323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41022.

avatar alikon
alikon - comment - 24 Jun 2023

I have tested this item successfully on 033a323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41022.

avatar Quy Quy - test_item - 24 Jun 2023 - Tested successfully
avatar Quy
Quy - comment - 24 Jun 2023

I have tested this item successfully on 033a323


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41022.

avatar Quy Quy - change - 24 Jun 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 24 Jun 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41022.

avatar Quy Quy - change - 24 Jun 2023
Labels Added: ?
avatar brianteeman
brianteeman - comment - 26 Jun 2023

good spot - thanks

avatar brianteeman
brianteeman - comment - 26 Jun 2023

@ChristineWk it was already corrected

avatar ChristineWk
ChristineWk - comment - 26 Jun 2023

OK, I saw it afterwards in another file.

avatar obuisard obuisard - close - 26 Jun 2023
avatar obuisard obuisard - merge - 26 Jun 2023
avatar obuisard obuisard - change - 26 Jun 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-26 15:32:06
Closed_By obuisard
avatar obuisard
obuisard - comment - 26 Jun 2023

Thank you Brian @brianteeman !

avatar brianteeman
brianteeman - comment - 26 Jun 2023

thx

Add a Comment

Login with GitHub to post a comment