PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Jun 2023

We should be using inclusive naming throughout the cms not just in the language strings.

Changes "master display controller" to "display controller",

Rationale

https://inclusivenaming.org/word-lists/tier-1/_master/

Test

Code review Only

Documentation

New page will be added to manual.joomla.org shortly

Note

This is part of a series of pull requests that are submitted separately to make reviewing easier

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2023
Category Administration com_banners com_messages com_modules com_newsfeeds com_plugins com_redirect com_templates com_users Front End com_content com_contenthistory
avatar brianteeman brianteeman - open - 23 Jun 2023
avatar brianteeman brianteeman - change - 23 Jun 2023
Status New Pending
avatar brianteeman brianteeman - change - 23 Jun 2023
Labels Added: PR-4.3-dev
avatar wilsonge
wilsonge - comment - 23 Jun 2023

Can we just drop the word all together. We don’t use any other controllers for display actions?

avatar brianteeman
brianteeman - comment - 23 Jun 2023

If there are no others then absolutely yes

avatar alikon alikon - test_item - 24 Jun 2023 - Tested successfully
avatar alikon
alikon - comment - 24 Jun 2023

I have tested this item successfully on 543a5f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41019.

avatar alikon
alikon - comment - 24 Jun 2023

I have tested this item successfully on 543a5f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41019.

avatar wilsonge
wilsonge - comment - 25 Jun 2023

If there are no others then absolutely yes

I'm not aware of any. I think this comment dates back to the fact this was the controller.php files in the component root back in joomla 3 https://github.com/joomla/joomla-cms/blob/3.10-dev/administrator/components/com_content/controller.php - but there's nothing so special about them really these days.

avatar brianteeman brianteeman - change - 25 Jun 2023
The description was changed
avatar brianteeman brianteeman - edited - 25 Jun 2023
avatar brianteeman
brianteeman - comment - 25 Jun 2023

@wilsonge updated as requested

avatar wilsonge wilsonge - change - 25 Jun 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-25 21:29:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 Jun 2023
avatar wilsonge wilsonge - merge - 25 Jun 2023
avatar wilsonge
wilsonge - comment - 25 Jun 2023

Thanks!

avatar brianteeman
brianteeman - comment - 25 Jun 2023

Thanks @wilsonge

Add a Comment

Login with GitHub to post a comment