Can we add in the unit tests you provided here please? https://gist.github.com/Achal-Aggarwal/9563815#file-typo-password-field-test

Thanks!

To test you need to check you can now correctly define the meter property in the password form field and input mode in the text form field

I'll add some UT's for this PR today.

Awesome :) thanks man!

@wilsonge

To test you need to check you can now correctly define the meter property in the password form field and input mode in the text form field

I'm happy to do it but how? where we use the password form field with meter property or how we can test it that it works?

If i understand this correkt we can set this by using meter="true" or meter="1" e.g. here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/models/forms/user.xml#L18-37

But I'm not sure what we change/add/remove/done ... with this attribut.
If I understand it should show a PasswordStrength form but i can't see it at my end.

I add meter="true" and threshold="1" to the form fileds above.

Moved the stuff to do with the password error into #5497

@Achal-Aggarwal and @wilsonge What is the status of this PR? What needs to be tested?

Several of these have been fixed elsewhere in core. Not sure what's left now - we probably need to merge in staging and see

I am fine to merge it, code review shows no issues. However the branch has conflicts, @Achal-Aggarwal can you fix those, so we can move this ahead?

@roland-d @Achal-Aggarwal has fixed the milestones so we are fine to merge?

Merged this, thanks. Unit tests ran fine and I tested it as well and all is good.