[#40989] - [5.2] Update PackageAdapter.php
- Closed
- 26 Nov 2024
- Medium
- Build: 4.3-dev
- # 40989
- Diff
- BrainforgeUK:patch-14
User tests: Successful: Unsuccessful:
Remove whitespace around extension folder names.
Pull Request for Issue # .
Summary of Changes
Apply trim() function to filename.
An alternative solution would be to remove the whitespace in the manifest.
But why? It is valid XML and the installation failure can catch extension developers by surprise.
Testing Instructions
Install attached test package.
test1.zip
Actual result BEFORE applying this Pull Request
Package installation fails.
Expected result AFTER applying this Pull Request
Package installation succeeds
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Oops - should have uninstalled Package Test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40989.
This pull request has been automatically rebased to 4.4-dev.
I have tested this item ✅ successfully on 1363286
Hi @BrainforgeUK, I have tested successfully but
- is this really necessary? ( I ask because would an extension developer not build his/her extension package correctly based on established process/documentation ).
I am definitely no expert, it just feels like we are trying to fix something that shouldn't exist in the real world and/or quite rare if the extension is built correctly. Mind you, I may be completely wrong.
- When I tried uninstalling your Package test1.zip, I received these error messages, FYI:
Warning
Package Uninstall: Missing manifest file.
info
Error uninstalling package.
| Title |
|
||||||
| Labels |
Added:
bug
PR-4.4-dev
|
||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Category | Libraries | ⇒ | Administration com_media Language & Strings Installation |
Hello @BrainforgeUK, something went wrong when switching the branches and you have now unrelated changes in your PR. Could you rebase the PR and fix those issues?
The original commit was a one file, one line change.
Looked like the easiest thing to do was to create a new pull request : 44530
Looks like I needed to revert everything on the original pull and start again.
Appears I don't have revert priviledge, even though its my pull request!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-26 16:09:31 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
Language Change
PR-5.2-dev
|
||
Since you recreated the PR, I'm closing this one.
I have tested this item ✅ successfully on 1363286
After install: uninstall com_test1, plg_quickicon_test1, plg_user_test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40989.