[#40989] - [4.4] Update PackageAdapter.php
- Pending
- Medium
- Build: 4.3-dev
- # 40989
- Diff
- BrainforgeUK:patch-14
User tests: Successful: Unsuccessful:
Remove whitespace around extension folder names.
Pull Request for Issue # .
Summary of Changes
Apply trim() function to filename.
An alternative solution would be to remove the whitespace in the manifest.
But why? It is valid XML and the installation failure can catch extension developers by surprise.
Testing Instructions
Install attached test package.
test1.zip
Actual result BEFORE applying this Pull Request
Package installation fails.
Expected result AFTER applying this Pull Request
Package installation succeeds
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
Oops - should have uninstalled Package Test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40989.
This pull request has been automatically rebased to 4.4-dev.
I have tested this item ✅ successfully on 1363286
Hi @BrainforgeUK, I have tested successfully but
- is this really necessary? ( I ask because would an extension developer not build his/her extension package correctly based on established process/documentation ).
I am definitely no expert, it just feels like we are trying to fix something that shouldn't exist in the real world and/or quite rare if the extension is built correctly. Mind you, I may be completely wrong.
- When I tried uninstalling your Package test1.zip, I received these error messages, FYI:
Warning
Package Uninstall: Missing manifest file.
info
Error uninstalling package.
| Title |
|
||||||
I have tested this item ✅ successfully on 1363286
After install: uninstall com_test1, plg_quickicon_test1, plg_user_test1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40989.