[#40987] - Banners 'Select By Keyword' Not Functional
- Closed
- 19 Jun 2023
- Medium
- Build: 4.3-dev
- # 40987
Problem identified
Banner component & module 'Select By Keyword' not working. e.g. adding keyword 'all' to an article and adding the same keyword to a banner module and related banner results in no banner showing.
I believe this is due to article keywords functionality being removed as it's no longer necessary for SEO. However this is necessary for the Banner component keyword targetting to behave correctly. Can we reinstate some form of keyword functionality?
Keywords 'are' working for related articles functionality which is promising, just not for banners.
Proposed solution
Reinstate keyword functionality for banners
Open questions
Is this possible?
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
richard67
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-19 16:24:36 |
| Closed_By | ⇒ | richard67 |
@cozioscob #39016 has not been merged yet - you could test this which would advance the process
@cozioscob #39016 has not been merged yet - you could test this which would advance the process
To be clear, I've:
-
Replaced BannersModel.php, ArticleModel.php, ArticlesModel.php, SiteApplication.php, BannersHelper.php from 39016 on my working site, no success (in fact it broke my site layout)
-
Replaced BannersModel.php, ArticleModel.php, ArticlesModel.php, SiteApplication.php, BannersHelper.php in a fresh install of 4.3.2 with no change to banner visibility using keyword setup
-
Replaced BannersModel.php, ArticleModel.php, ArticlesModel.php, SiteApplication.php, BannersHelper.php in a fresh install of 4.4.0-alpha2-dev with no change to banner visibility using keyword setup
@cozioscob You can try with the packages from here: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.3-dev/39016/downloads/66712/ - i tested this and it works fine.
Managed to work out the issue.
If Client is set to 'No Client' in the module then no banners will display, choosing a client works with the above and keywords enabled.
Error with no client selected is
Warning: Undefined array key 4 in ----/public_html/components/com_banners/src/Model/BannersModel.php on line 231
Using 'No Client' is my preferred as it then pulls in banners from all clients and uses keywords to prioritise banners related to several different clients.
Hope that helps?
(I'm also seeing a 1064 error on my home page only which disappears if I unpublish the banner modules from home, might be related)
Thank you very much - could you please open a new issue for the "No client" problem - i can then look into it. A screenshot of the 1064 error would also be helpful
#39016