? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
19 Jun 2023

Pull Request for Issue #40787 .

Summary of Changes

If there's a modified_date use it (as unix timestamp) else fallback to the existing mediaversion

Screenshot 2023-06-19 at 15 55 21

Testing Instructions

  • Apply the PR
  • Edit an image
  • check that the rest of the images are loaded from the cache

Actual result BEFORE applying this Pull Request

Cache is always invalidated

Expected result AFTER applying this Pull Request

Cache is invalidated only for items/files with different modified date

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 19 Jun 2023
Category Administration com_media NPM Change
avatar dgrammatiko dgrammatiko - open - 19 Jun 2023
avatar dgrammatiko dgrammatiko - change - 19 Jun 2023
Status New Pending
avatar dgrammatiko dgrammatiko - change - 19 Jun 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar dgrammatiko dgrammatiko - change - 19 Jun 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 19 Jun 2023
avatar viocassel viocassel - test_item - 19 Jun 2023 - Tested successfully
avatar viocassel
viocassel - comment - 19 Jun 2023

I have tested this item successfully on 560080b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40893.

avatar laoneo laoneo - test_item - 21 Jun 2023 - Tested successfully
avatar laoneo
laoneo - comment - 21 Jun 2023

I have tested this item successfully on 560080b

Tested it and the edited image got a new timestamp and the new one is loaded. Before it could happen that the old image was loaded in the list when the browser has cached the old image.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40893.

avatar laoneo laoneo - change - 21 Jun 2023
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 21 Jun 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40893.

avatar laoneo laoneo - change - 21 Jun 2023
Labels Added: ?
avatar Mich-es Mich-es - test_item - 21 Jun 2023 - Tested successfully
avatar Mich-es
Mich-es - comment - 21 Jun 2023

I have tested this item successfully on e469855

Great - it works for me THX


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40893.

avatar laoneo
laoneo - comment - 21 Jun 2023

Can you guys also test #40704 as it restores the old behavior in the media manager.

avatar richard67 richard67 - alter_testresult - 21 Jun 2023 - viocassel: Tested successfully
avatar richard67 richard67 - alter_testresult - 21 Jun 2023 - laoneo: Tested successfully
avatar obuisard obuisard - close - 23 Jun 2023
avatar obuisard obuisard - merge - 23 Jun 2023
avatar obuisard obuisard - change - 23 Jun 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-23 20:46:56
Closed_By obuisard
avatar obuisard
obuisard - comment - 23 Jun 2023

Thank you Dimitris @dgrammatiko for this PR!

Add a Comment

Login with GitHub to post a comment