Joomla! Issue Tracker | Joomla! CMS #4077

Closed
7 Aug 2014
Medium
Build: staging
# 4077
Diff
peterlose:icon

Success

Success The Travis CI build passed Details

User tests: Successful: Unsuccessful:

peterlose
6 Aug 2014

Based on PR #4075 it was made possible to add icons to JToolbar popup buttons instead of the hardcoded icon-cog. This removed an icon from different views in com_finder.

This PR adds new icons, as no icomoon icon is called icon-stats, to the statistics button.

In order to test this PR, you need to test against the current staging branch, as PR #4075 is already merged.

8753004 6 Aug 2014

Missing icons

losedk - open - 6 Aug 2014

jissues-bot - change - 6 Aug 2014

Labels

Added: ? ?

losedk - comment - 6 Aug 2014

Joomlacode is kinda slow right now, so I'm going to create a tracker when it's up again

n9iels - comment - 7 Aug 2014

@test doesn't work for me, but I think thats because I have to apply #4075 in the patach tester together with this one. That not possible because it is already closed and the patch tester do not display closed PR's. Maybe you can update the test instructions if this is correct

Bakual - comment - 7 Aug 2014

Tested fine. Thanks for that!

@n9iels You should be able to update to the latest nightly build by selecting the test options in the update stream.

losedk - comment - 7 Aug 2014

@n9iels as @Bakual mention you should test on the current staging branch, as #4075 is merged already.

losedk - comment - 7 Aug 2014

@n9iels as @Bakual mention you should test against the current staging branch, as @4075 is already merged.

infograf768 - change - 7 Aug 2014

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2014-08-07 08:17:57

infograf768 - close - 7 Aug 2014

infograf768 - comment - 7 Aug 2014

Thanks. Merged.
Will now prepare a patch for Hathor for #4075 as well as #4077

infograf768 - comment - 7 Aug 2014

Please test
#4078

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#4077] - Missing icons

Add a Comment