[#40758] - [4][com_newsfeed] hits must be 0 on new item
- Fixed in Code Base
- 17 Jun 2023
- Medium
- Build: 4.3-dev
- # 40758
- Diff
- alikon:patch-16
User tests: Successful: Unsuccessful:
Pull Request for Issue (#40741 (comment)) .
Summary of Changes
set 0 for hits on new item
Testing Instructions
use postgresql to replicate
create a newsfeed
Actual result BEFORE applying this Pull Request
error on postgresql
Expected result AFTER applying this Pull Request
mysql & postgresql both work
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_newsfeeds |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40758.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40758.
Does this mean we are not calling check on new items?
| Status | Ready to Commit | ⇒ | Information Required |
Does this mean we are not calling check on new items?
I looked at the execution pipeline and it should trigger the check function in AdminModel::save() at line 1251.
btw. all other components I checked use the check function to set the hit count so this pr is not the best way to fix it.
Does this mean we are not calling check on new items?
I looked at the execution pipeline and it should trigger the check function in AdminModel::save() at line 1251.
btw. all other components I checked use the check function to set the hit count so this pr is not the best way to fix it.
Hmm, maybe the if (is_null($this->hits)) in the check function is the problem? Maybe it should be an if (!isset($this->hits))?
Forget it, thinking about it that should not be the case.
update the original if statement to not catch NULL values only
If you do that you'll reset the hits every time you update the item. Postgres presumably isn't treating the value as null or something?
I didn't mean every not null value, if you read my whole comment then I do suggest something like `if (!$this->hits)
| Labels |
Added:
bug
PR-4.3-dev
|
||
anyway...
check now please
I have tested this item
Newsfeed can be added on postgres
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40758.
@Kaushik1216 can you test this one again?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40758.
| Status | Information Required | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40758.
obuisard
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-17 17:01:12 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 74784d9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40758.