? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
6 Aug 2014

How to test

  1. Access the Backend Banner Manager
  2. Access the "Trackes" view
  3. See the icon bevor the "Export" Button (icon-cog)
  4. apply patch
  5. see the download icon (icon-download)

Why change export --> download

We have no icon-export see: http://www.nonr.nl/jui/index.php/icons

But a download icon (icon-download)

Tracker

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34041&start=0

avatar zero-24 zero-24 - open - 6 Aug 2014
avatar jissues-bot jissues-bot - change - 6 Aug 2014
Labels Added: ? ?
avatar jissues-bot jissues-bot - change - 6 Aug 2014
Title
JToolbar Popup button modal icon class not customizable
[#34041] JToolbar Popup button modal icon class not customizable
avatar jissues-bot jissues-bot - change - 6 Aug 2014
Title
JToolbar Popup button modal icon class not customizable
[#34041] JToolbar Popup button modal icon class not customizable
avatar n9iels
n9iels - comment - 6 Aug 2014

@test works fine for me, this icon fits better by the function of the button

avatar zero-24
zero-24 - comment - 6 Aug 2014

Thanks @n9iels one more tester.

avatar losedk
losedk - comment - 6 Aug 2014

Test. All good!

avatar zero-24
zero-24 - comment - 6 Aug 2014

Thanks @losedk I moving the Tracker to RTC

avatar Bakual Bakual - change - 6 Aug 2014
Labels Added: ?
avatar losedk
losedk - comment - 6 Aug 2014

@zero-24 just noticed an error after testing it. Line 42 in tracks > tmpl > default.php

window.jQuery('#modal-export').modal('hide');

should be changed to

window.jQuery('#modal-download').modal('hide');

Or the cancel button won't close the modal

avatar Bakual Bakual - change - 6 Aug 2014
Labels Removed: ?
avatar zero-24
zero-24 - comment - 6 Aug 2014

thanks @losedk fixed

avatar losedk
losedk - comment - 6 Aug 2014

:+1:

avatar losedk
losedk - comment - 6 Aug 2014

All good now

avatar Bakual Bakual - change - 6 Aug 2014
Labels Added: ?
avatar Bakual Bakual - change - 6 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-06 19:05:59
avatar Bakual Bakual - close - 6 Aug 2014
avatar beni71
beni71 - comment - 6 Aug 2014

There is another button icon disapeared: The icon of the button statistic of all three views (index, maps, filters) of the com_finder. I think we must change the class 'stats' in one of 'pie', 'bars' or 'charts'.

avatar losedk
losedk - comment - 6 Aug 2014

@beni71 Didn't notice that one :/

I'm making a PR to fix it. Which icon do you prefer?

icons

avatar beni71
beni71 - comment - 6 Aug 2014

If we don't have to follow any guidelines, i would prefer the last one.

Am 06.08.2014 um 23:54 schrieb Peter Lose:

@beni71 https://github.com/beni71 Didn't notice that one :/

I'm making a PR to fix it. Which icon do you prefer?

icons
https://cloud.githubusercontent.com/assets/1738811/3834679/212531bc-1db4-11e4-923f-1244e5b5068f.png


Reply to this email directly or view it on GitHub
#4075 (comment).

avatar losedk
losedk - comment - 6 Aug 2014

Yeah me to. None of them are used at the moment, so I guess it doesn't matter

avatar losedk
losedk - comment - 6 Aug 2014

@beni71 could you test #4077 ?

avatar infograf768
infograf768 - comment - 7 Aug 2014

Please test #4078

avatar beni71
beni71 - comment - 9 Aug 2014

Test ok. I din't have found missing icons.

Add a Comment

Login with GitHub to post a comment