[#40715] - Display quickicons only for active components
- Fixed in Code Base
- 11 Jun 2023
- Medium
- Build: 4.3-dev
- # 40715
- Diff
- chmst:quickicons-only-active-component
User tests: Successful: Unsuccessful:
Pull Request for Issue #40684 .
When components are disabled, they don't show up in the components menu, but in quick icos.
This PR hides also quickicons for disabled components.
Summary of Changes
Check if a component is enabled before rendering a quicicon.
Testing Instructions
see #40684
Activate quickicons for unprotected components ( tags, banners, contacts, newsfeeds, finder, workflows, associations)
Check if they are displayed.
Then disable these components.
Check again - the quickicons ar no longer displayed.
If you re-activates the components, they come back.
Actual result BEFORE applying this Pull Request
Quickicons to disabled components are displayed
Expected result AFTER applying this Pull Request
Quickicons to disabled components are not displayed
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Status | New | ⇒ | Pending |
This does not work for workflow. Double-check empirically - turn on the integration, then the icon will disappear. Also, the component is protected and cannot be disabled in extension management. You need a condition - to enable / disable integration in the settings of the article component, and not enable / disable the component in principle.
| Labels |
Added:
bug
PR-4.3-dev
?
|
||
@brianteeman I think it is better to make quickicons in the same way as the main menu.
If the menu doesn't show disabled components, why should we show them in quickicons?
@Kostelano workflow indeed is a special case. We have one icon for workflow - but no specification for which component the worfkow is enabled.
workflow indeed is a special case. We have one icon for workflow - but no specification for which component the worfkow is enabled.
So what does your new condition do for the workflow? The component is protected and cannot be disabled. The condition should be removed in my opinion.
By analogy with menu items - we do not need to show something that is not enabled (in this case, not integrated in the article settings). The same applies to the multilingual component, but this component can still be disabled, so the condition for it is correct.
I have tested this item
After the changes I send a successful test, it works. And it makes sense.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40715.
@brianteeman I think it is better to make quickicons in the same way as the main menu. If the menu doesn't show disabled components, why should we show them in quickicons?
By that logic the option to set them should also be removed from the module
We don't remove the menu links from the main menu, if a component is disabled, we just don't show the link if the componet is disabled.
Removing the options from the module needs more programming, but you could make an alternative PR. Will be happy to test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40715.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40715.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-11 23:59:29 |
| Closed_By | ⇒ | obuisard |
#40684 (comment)