PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
3 Jun 2023

Pull Request for Issue # .

Summary of Changes

To make the EOS quickicon plugin work for 5.x in the right way, it needs to be adapted. This has to be done with every new major version. This pull request (PR) here does that for version 5.

In detail following is changed:

  • Adapt the EOS_DATE constant to the right end of support date.
  • Adapt the doc block comment of that constant to the right major version.
  • Update the version number in the plugin's manifest XML to show it was changed.

For Joomla 5 the end of support is November 17, 2027, as stated in the project road map.

As it is not decided with minor version will be the last Joomla 5 version, the doc block comment is changed to The EOS date for 5.x., which fits to what the road map says ("End of Support for 5.x").

To be done with a future PR when documentation is available

The message links have to be adjusted, too, because they have URLs specific to the next major version, which would be 6, but that would lead to 404 links if we would do that now as long as the linked documentation doesn't exist for Joomla 6.

These are the four 'messageLink's here:

They point to following two URLs for which it needs to create the Joomla 6 equivalents:

One link points to https://docs.joomla.org/Special:MyLanguage/Pre-Update_Check which seems not to depend on the major version:

It seems it needs similar adjustments also on the 4.4-dev branch for having the right links to documentation for migrating from 4.4 to 5.

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

EOS plugin uses comment and EOS date for Joomla 4.4.

Expected result AFTER applying this Pull Request

EOS plugin uses comment and EOS date for Joomla 5.x.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 3 Jun 2023
Category Front End Plugins
avatar richard67 richard67 - open - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
Status New Pending
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 3 Jun 2023
The description was changed
avatar richard67 richard67 - edited - 3 Jun 2023
avatar richard67 richard67 - change - 4 Jun 2023
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - change - 4 Jun 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-04 20:05:13
Closed_By HLeithner
avatar HLeithner HLeithner - close - 4 Jun 2023
avatar HLeithner HLeithner - merge - 4 Jun 2023
avatar HLeithner
HLeithner - comment - 4 Jun 2023

Thanks

Add a Comment

Login with GitHub to post a comment