Feature Language Change PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
2 Jun 2023

Summary of Changes

Adds the guided tours component to the alternate menu preset

Testing Instructions

Go to the module manager and filter on admin modules
Open the admin menu module
Change the preset from Joomla Main Meunu to Alternative Main Menu

Actual result BEFORE applying this Pull Request

Guided Tours is not present in the components submenu

Expected result AFTER applying this Pull Request

Guided tours is now available

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2023
Category Administration com_menus
avatar brianteeman brianteeman - open - 2 Jun 2023
avatar brianteeman brianteeman - change - 2 Jun 2023
Status New Pending
avatar toivo toivo - test_item - 4 Jun 2023 - Tested successfully
avatar toivo
toivo - comment - 4 Jun 2023

I have tested this item successfully on e00caf0

Tested successfully in Joomla 4.3.3-dev of 4 June in Wampserver 3.3.6 using PHP 8.2.6.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40707.

avatar Quy Quy - test_item - 4 Jun 2023 - Tested successfully
avatar Quy
Quy - comment - 4 Jun 2023

I have tested this item successfully on e00caf0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40707.

avatar Quy Quy - change - 4 Jun 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev Feature
avatar Quy
Quy - comment - 4 Jun 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40707.

avatar Quy Quy - change - 4 Jun 2023
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jun 2023
Category Administration com_menus Administration com_joomlaupdate com_menus Language & Strings Modules Installation
avatar obuisard obuisard - change - 9 Jun 2023
Title
[4.3] Add guided tours to alternate menu preset
[5.0] Add guided tours to alternate menu preset
avatar obuisard obuisard - edited - 9 Jun 2023
avatar HLeithner
HLeithner - comment - 15 Jun 2023

could you please resolve the conflict

avatar brianteeman
brianteeman - comment - 15 Jun 2023

This was a bug fix not a new feature. The conflicts and all the extra files were caused by the pointless changes made to try and rebase the pr it needs completely rebuilding :(

avatar brianteeman brianteeman - change - 15 Jun 2023
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2023-06-15 07:20:41
Closed_By brianteeman
Labels Added: PR-5.0-dev
Removed: PR-4.3-dev
avatar brianteeman brianteeman - close - 15 Jun 2023
avatar HLeithner
HLeithner - comment - 15 Jun 2023

It was only one file with a conflict, if you undelete your branch I can do the conflict resolution for you

avatar brianteeman
brianteeman - comment - 15 Jun 2023

there were 87 unrelated files

avatar HLeithner
HLeithner - comment - 15 Jun 2023

true but they could

avatar HLeithner HLeithner - change - 15 Jun 2023
Status Closed New
Closed_Date 2023-06-15 07:20:41
Closed_By brianteeman
Labels Added: Language Change
Removed: ?
avatar HLeithner HLeithner - change - 15 Jun 2023
Status New Pending
avatar HLeithner HLeithner - reopen - 15 Jun 2023
avatar HLeithner HLeithner - change - 15 Jun 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-06-15 08:08:02
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 15 Jun 2023

Ok, I see you have created a new pr then I close this again

avatar HLeithner HLeithner - close - 15 Jun 2023

Add a Comment

Login with GitHub to post a comment