[#40694] - [5.3] Move 2 worflows input fields translations to global constants to separate from com_content
- Pending
- Medium
- Build: 4.3-dev
- # 40694
- Diff
- artur-stepien:master
User tests: Successful: Unsuccessful:
Summary of Changes
This pull requests detaches workflow dropdown inputs from com_content component. It is required or other components using Workflows would require using COM_CONTENT translations or its translation prefix.
Testing Instructions
To test it fully you would require to build a custom component running workflows. Easiest is to check if Workflow input in Article Edit view and Articles list in administration still have the translation like previously:
- Run Translation
- Workflow Stage
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
The inputs marked in screens above should have the same translation before and after patch.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Layout Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
PR-4.3-dev
|
||
| Labels |
Added:
bug
|
||
Thanks for the pr, I'v rebased it to 5.0 so it will get more attention for the pizza bugs and fun.
Should the Article Edit view use the new constant?
Should the Article Edit view use the new constant?
Should, that's why there is a change in layouts/joomla/button/transition-button.php and libraries/src/MVC/Model/WorkflowBehaviorTrait.php and from what I saw it affected the com_content. I will test it again and let you know.
Tested but waiting for the outcome of previous comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40694.
Tested but waiting for the outcome of previous comment.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40694.
I will try to find the time for this tomorrow.
| Title |
|
||||||
This needs documentaion in the release notes for the situation someone has an overwrite for the language tag.
| Labels |
Added:
Feature
Documentation Required
?
Maintainers Checked
PR-5.0-dev
Removed: bug PR-4.3-dev |
||
| Labels |
Added:
Updates Requested
PR-5.1-dev
Removed: Documentation Required ? |
||
| Category | Administration Language & Strings Layout Libraries | ⇒ | Unit Tests Repository Administration com_admin com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_media NPM Change JavaScript com_menus com_messages |
Can you make the requested change so that we can test it during PBF next saturday?
Actually, the PR seems to be broken right now, since it was rebased.
| Labels |
Added:
Unit/System Tests
NPM Resource Changed
Removed: Language Change |
||
| Category | Administration Unit Tests Repository com_admin com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_media NPM Change JavaScript com_menus com_messages | ⇒ | Administration Language & Strings Layout Libraries |
| Labels |
Added:
Language Change
Removed: Unit/System Tests NPM Resource Changed |
||
| Labels |
Removed:
Feature
PR-5.0-dev
|
||
Should, that's why there is a change in
layouts/joomla/button/transition-button.phpandlibraries/src/MVC/Model/WorkflowBehaviorTrait.phpand from what I saw it affected the com_content. I will test it again and let you know.
This still needs to be changed.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
@Quy @richard67 Willing to check this out? It was created over a month ago.