Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40687] - [4.3] Backport of Smart Search: Fixing taxonomy filter handling

? PBF bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
31 May 2023

Backport of PR #39751 that was merged into 5.0.
This should have been included in 4.3 and was overlooked.
Our sincere apologies to the author of the original PR, Hannes @Hackwar.

Summary of Changes

When the taxonomies were refactored to be a nested set, this part was overlooked. This means that nested taxonomies in filters don't work.

Testing Instructions

  1. Create an article in a category which is at least on the second level.
  2. Create a filter which only searches in that articles parent category.
  3. Go to the frontend and search for a word in that article. You will get the article as result.
  4. Add &f=[filter-id] to the URL to only show results from our category.
  5. Notice that you get no result at all!
  6. Apply changes.
  7. Only the article appears again.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2023
Category ⇒ Administration com_finder
avatar obuisard obuisard - open - 31 May 2023
avatar obuisard obuisard - change - 31 May 2023
Status New ⇒ Pending
avatar wilsonge
wilsonge - comment - 31 May 2023

Just FYI backporting things like this is going to cause you major merge conflicts once this is merged and you need to merge 4.3-dev into 5.0-dev

avatar Sabine-2023 Sabine-2023 - test_item - 26 Aug 2023 - Tested successfully
avatar Sabine-2023
Sabine-2023 - comment - 26 Aug 2023

I have tested this item ✅ successfully on b1c9c91

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40687.

avatar ceus1984 ceus1984 - test_item - 26 Aug 2023 - Tested successfully
avatar ceus1984
ceus1984 - comment - 26 Aug 2023

I have tested this item ✅ successfully on b1c9c91

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40687.

avatar richard67 richard67 - change - 26 Aug 2023
Status Pending ⇒ Ready to Commit
Labels Added: PBF bug PR-4.3-dev
avatar richard67
richard67 - comment - 26 Aug 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40687.

avatar obuisard obuisard - change - 29 Aug 2023
Labels Added: ?
avatar sdwjoomla sdwjoomla - change - 29 Aug 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-29 14:57:31
Closed_By ⇒ sdwjoomla
avatar sdwjoomla sdwjoomla - close - 29 Aug 2023
avatar sdwjoomla sdwjoomla - merge - 29 Aug 2023
avatar sdwjoomla
sdwjoomla - comment - 29 Aug 2023

Thanks @Hackwar

Add a Comment

Login with GitHub to post a comment