[#40675] - [5.2] Remove alt-text for menuItem with image and title
- Fixed in Code Base
- 18 Jan 2025
- Medium
- Build: 4.4-dev
- # 40675
- Diff
- chmst:a11y-menu-module-alt
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In the menu layouts menus can have an image followed by an text. Alt-text for images are generated equal to the menuitem title. If the menutype is a link, this is an a11y issue, in other cases it is useless.
This PR replaces the alt text by an empty alt-text for all menutypes.
Testing Instructions
Code inspect and sourcecode inspect.
Or use a tool like IBM accessible audit in your browser and check your menus with images.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
x] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[x No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Front End Templates (site) |
| Status | New | ⇒ | Pending |
| Labels |
Added:
a11y
bug
PR-4.3-dev
|
||
When Display Menu Item Title is disabled, then won't it be an a11y issue without the alt text?
No, as there is the menu item text , but hidden for sighted users
<span class="visually-hidden">' . $item->title . '</span>'
But this is not the case as seen below:
<li class="nav-item item-101"><a href="/joomla-cms-4.3-dev/index.php/home" ><img src="/joomla-cms-4.3-dev/images/joomla_black.png" alt="" width="225" height="50" loading="lazy"></a></li>
Thank you for testing - will fix this asap
| Labels |
Added:
?
|
||
I have tested this item ✅ successfully on b63b611
Using axe DevTools the menu image was flagged as Alternative text of images should not be repeated as text. With the patch that flag disappeared.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675.
This pull request has been automatically rebased to 4.4-dev.
So any news here? Still open. Btw you may add "width" & "height" attributes to this <img> as well.
So any news here? Still open. Btw you may add "width" & "height" attributes to this
<img>as well.
The attributes width and height are not required for an img element.
The preserve the required space on a html page one can also use aspect-ratio
@chmst can you fix the error "This branch is out-of-date with the base branch" by merging most resent branch 4.4-dev into it?
| Labels |
Added:
PR-4.4-dev
Removed: ? PR-4.3-dev |
||
The attributes
widthandheightare not required for animgelement. The preserve the required space on a html page one can also use aspect-ratio
@hans2103 Many things are not required, but I want a 100 score on PageSpeed Insights. :)
Probably some day. But for one icon only...
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
| Build | 4.3-dev | ⇒ | 4.4-dev |
This one here is not RTC, it has only one test.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as it has only one test
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675.
| Labels |
Removed:
RTC
|
||
I have tested this item ✅ successfully on 87b1361
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675.
| Labels |
Added:
Updates Requested
|
||
| Labels |
Removed:
Updates Requested
|
||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
I have tested this item ✅ successfully on 731bba0
Works fine. It adds an empty ALT to the purely decorative menu item image
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40675.
| Labels |
Added:
RTC
PR-5.2-dev
Removed: PR-4.4-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-01-18 14:04:56 |
| Closed_By | ⇒ | rdeutz |
LGTM