[#40670] - Fixed url of joomla update error help button
- Fixed in Code Base
- 2 Jun 2023
- Medium
- Build: 4.3-dev
- # 40670
- Diff
- beni71:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #39769
Summary of Changes
Fixed/changed the url of the joomla update error help button
Testing Instructions
(It doesn't update joomla, it generates an error instead)
- In the backend navigate to System
- Under "Update" click Joomla. You will see the view of: administrator/index.php?option=com_joomlaupdate
- Click the button "Upload and Update"
- Instead of selecting a regular zipped version on Joomla, select a picture of type .png
- Set the check box "I'm aware that a backup before any update is highly recommended."
- Click the button "Upload & Install"
- Confirm the action, if needed and start the installation.
- This should result in an error like:
- Click on the button "Get help with this error"
Actual result BEFORE applying this Pull Request
Instead of showing a help page, there is an error:
404 - RuntimeException
Error fetching page from MediaWiki API: The page you specified doesn't exist.
=> url: https://help.joomla.org/proxy?keyref=Help43:JHELP_COMPONENTS_JOOMLA_UPDATE&lang=en
Expected result AFTER applying this Pull Request
The following help/doc page should be visualized:
Joomla Update Problems
(the content of this page is under construction)
=> url: https://docs.joomla.org/Special:MyLanguage/J4.x:Joomla_Update_Problems
Link to documentations
Please select:
-
Documentation link for docs.joomla.org: https://docs.joomla.org/Special:MyLanguage/J4.x:Joomla_Update_Problems
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40670.
not convinced that it is correct to change the url from the help domain
not convinced that it is correct to change the url from the help domain
I think it needs to be checked by the release leads. @sdwjoomla @obuisard
| Status | Pending | ⇒ | Ready to Commit |
RTC as it has 2 successful tests (which might get lost in the counter when doing a branch update). But it still requires a final decision.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40670.
This particular page is not used as a Help page via a Help button. It is used as an external link. That is why I suggested it should have the J4.x namespace. It is similar to the Forgot your login details? link on the Admin login page.
What I can see at first glance is that the help language key is not translated. The page it points to DOES exist: https://help.joomla.org/proxy?keyref=Help43:Components_Joomla_Update&lang=en. We should probably fix the area in the code where the language key is supposed to be replaced with its translation.
We should probably have
$helpUrl = Help::createUrl(Text::_('JHELP_COMPONENTS_JOOMLA_UPDATE'), false);
rather than the new URL.
Search for all instance of JHELP_ in the .ini files of a Joomla 4 installation. There are none! Search for all Instance in .php files - there are 4 but no way use them. All of these JHELP language strings were removed for the Joomla 4 release. Look at the bottom of any admin HtmlView page. You will see the actual filename. Example: $toolbar->help('Articles');
Yes, I just realized that looking at the code.
Then the proper replacement should be:
$helpUrl = Help::createUrl('Components_Joomla_Update', false);
Yes, I just realized that looking at the code. Then the proper replacement should be:
$helpUrl = Help::createUrl('Components_Joomla_Update', false);
No! Leave it exactly as it is in the PR we tested. This is an external link that should not go through the proxy server. And you keep quoting an out of date naming convention. This filename is the same as the title. This is Joomla Update Problems and not Components Joomla Update.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-02 23:23:33 |
| Closed_By | ⇒ | sdwjoomla |
Thanks beni71
I have tested this item✅ successfully on 0727587
I have updated the referenced page with a revised introduction and some screen shots. I also learned a few things! Good to go.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40670.