? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar BrainforgeUK
BrainforgeUK
27 May 2023

Corrected language .ini file handling in child templates.

Pull Request for Issue #40660 .

Summary of Changes

Corected loading of core and/or local language file(s).

Testing Instructions

Install the following very simple child templates (test1, test2(:

tpl_cassiopeia_test1.zip

tpl_cassiopeia_test2.zip

Actual result BEFORE applying this Pull Request

actual-screenshot

Expected result AFTER applying this Pull Request

expected-screenshot

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [*] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [*] No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 27 May 2023
Category Administration com_templates
avatar BrainforgeUK BrainforgeUK - open - 27 May 2023
avatar BrainforgeUK BrainforgeUK - change - 27 May 2023
Status New Pending
avatar ChristineWk
ChristineWk - comment - 27 May 2023

@BrainforgeUK

got this message:

screen shot 2023-05-27 at 10 07 22

but template folder is writeable.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40665.

avatar BrainforgeUK
BrainforgeUK - comment - 27 May 2023

A benign issue, no media files in my test child templates! See ...
https://issues.joomla.org/tracker/joomla-cms/40666

avatar BrainforgeUK
BrainforgeUK - comment - 27 May 2023

Additional pull request created to fix benign message.
#40667

avatar brianteeman
brianteeman - comment - 27 May 2023

Seems very odd to me that this is needed as I have had no problems at all with child templates and language strings.

image

You can try any of the zip files at https://github.com/brianteeman/joomlachild/tree/main/examples they are all child templates of cassiopeia

avatar obuisard obuisard - change - 11 Aug 2023
Labels Added: bug PR-4.3-dev
avatar BrainforgeUK
BrainforgeUK - comment - 11 Aug 2023

Is this requiring any action on my part?

avatar obuisard
obuisard - comment - 14 Aug 2023

Is this requiring any action on my part?

No, thanks for the PR Jonathan @BrainforgeUK, we now need people to test :-)

avatar robinclapp robinclapp - test_item - 26 Aug 2023 - Tested successfully
avatar blanderson22 blanderson22 - test_item - 26 Aug 2023 - Tested successfully
avatar robinclapp
robinclapp - comment - 26 Aug 2023

I have tested this item ✅ successfully on a174660


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40665.

avatar blanderson22
blanderson22 - comment - 26 Aug 2023

I have tested this item ✅ successfully on a174660


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40665.

avatar richard67 richard67 - change - 26 Aug 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Aug 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40665.

avatar obuisard obuisard - change - 29 Aug 2023
Labels Added: ?
avatar obuisard obuisard - change - 29 Aug 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-29 13:12:38
Closed_By obuisard
avatar obuisard obuisard - close - 29 Aug 2023
avatar obuisard obuisard - merge - 29 Aug 2023
avatar obuisard
obuisard - comment - 29 Aug 2023

Thank you Jonathan @BrainforgeUK for the PR.

Add a Comment

Login with GitHub to post a comment