Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40652] - Followup work for the EOS plugin

PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
24 May 2023

Followup Pull Request for #40556 .

Summary of Changes

PHP 7.2 compatibility and small cosmetic changes.

avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2023
Category ⇒ Front End Plugins JavaScript Unit Tests
avatar laoneo laoneo - open - 24 May 2023
avatar laoneo laoneo - change - 24 May 2023
Status New ⇒ Pending
avatar laoneo laoneo - change - 24 May 2023
Labels Added: ? PR-4.4-dev
b2eb630 24 May 2023 avatar laoneo cs
avatar brianteeman
brianteeman - comment - 24 May 2023

apart from making the code longer and harder ro read what is the purpose of not using Text:: like the rest of joomla.

avatar richard67
richard67 - comment - 24 May 2023

@laoneo It seems you have linked the wrong PR in the description. You've linked the old, closed #40556 and not the merged #40565 .

292e63e 25 May 2023 avatar laoneo guest
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2023
Category Front End Plugins JavaScript Unit Tests ⇒ Front End Plugins
avatar laoneo laoneo - change - 25 May 2023
Labels Removed: ?
3ef40f9 25 May 2023 avatar laoneo debug
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2023
Category Front End Plugins ⇒ SQL Installation Postgresql Front End Plugins
avatar sandewt
sandewt - comment - 25 May 2023

apart from making the code longer and harder ro read what is the purpose of not using Text:: like the rest of joomla.

@laona Is it not (or soon) possible to replace Text::_ by $this->_ as in the pr 'Introduce a language aware interface #40614' ?

It would be nice to use this method here too.

avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2023
Category Front End Plugins SQL Installation Postgresql ⇒ Front End Plugins
ea0ead1 25 May 2023 avatar laoneo cs
avatar laoneo
laoneo - comment - 25 May 2023

We can then adapt it afterwards. For now I just want to make the system tests on drone working again.

avatar laoneo laoneo - change - 25 May 2023
The description was changed
avatar laoneo laoneo - edited - 25 May 2023
e2ba414 25 May 2023 avatar laoneo date
avatar MacJoom MacJoom - change - 25 May 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-05-25 19:23:17
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 25 May 2023
avatar MacJoom MacJoom - merge - 25 May 2023

Add a Comment

Login with GitHub to post a comment