No Code Attached Yet
avatar brianteeman
brianteeman
22 May 2023

Steps to reproduce the issue

Until Joomla 5.0 (#38209) composer.json referenced joomla/ldap

I am assuming it was removed intentionally?

If it was intentional then there is a problem in libraries\classmap.php which still references it

JLoader::registerAlias('JClientLdap', '\\Joomla\\Ldap\\LdapClient', '6.0');
JLoader::registerAlias('JLDAP', '\\Joomla\\Ldap\\LdapClient', '4.0');

Amongst presumably other things this results in an error when running the stubgenerator

avatar brianteeman brianteeman - open - 22 May 2023
avatar joomla-cms-bot joomla-cms-bot - change - 22 May 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 22 May 2023
avatar HLeithner
HLeithner - comment - 22 May 2023

Yes was intentionally, also missed to add it to the manual b/c breaks...

I think the stub generator doesn't create this file, it's maintained manually isn't it?

avatar brianteeman
brianteeman - comment - 22 May 2023

The stub generator parses the classmap.php - no idea how that is maintained - sorry

avatar HLeithner
HLeithner - comment - 22 May 2023

Seems to be manually f5442b3

I will do a pr when nobody else is faster then me later. thanks

avatar brianteeman
brianteeman - comment - 23 May 2023

I notice that it says deprecated ibn 6.0 but its already been removed?

avatar HLeithner
HLeithner - comment - 23 May 2023

wrong deprecation for this class, the problem is we can't support it anymore in 5.0 because the dependency doesn't fit iirc.
Also I think only joomla it selft used it in 3 and no longer in 4, all other ldap plugins that I know of use there own ldap lib.

But I will add it to the list of additional deprecation votes for production.

avatar brianteeman
brianteeman - comment - 1 Aug 2023

But I will add it to the list of additional deprecation votes for production.

did anything happen?

avatar HLeithner
HLeithner - comment - 1 Aug 2023

Motion PROD2023/004 passed which includes this, I'm closing this as expected change, ok for you?

avatar HLeithner HLeithner - change - 1 Aug 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-08-01 21:13:12
Closed_By HLeithner
avatar HLeithner HLeithner - close - 1 Aug 2023
avatar brianteeman
brianteeman - comment - 1 Aug 2023

dont you still need to update the classmap then?

avatar HLeithner
HLeithner - comment - 1 Aug 2023

true I created a Pr #41302

Add a Comment

Login with GitHub to post a comment