Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40637] - [4.3] Fix check create article menu item with specific category

? Language Change bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
21 May 2023

Pull Request for Issue #17708 .

Summary of Changes

as we have a onContentBeforeSave in J4 to deal with workflows. Nothing should have changed - it should be cosmetic - but just to document the change in case.

checkMenuItemBeforeSave is called when context is com_menus.item

joomla-cms/plugins/content/joomla/joomla.php

Lines 66 to 70 in c3593e9

public function onContentBeforeSave($context, $table, $isNew, $data)
{
if ($context === 'com_menus.item') {
return $this->checkMenuItemBeforeSave($context, $table, $isNew, $data);
}

checkMenuItemBeforeSave always return true when context is com_menus.item

joomla-cms/plugins/content/joomla/joomla.php

Lines 594 to 599 in c3593e9

private function checkMenuItemBeforeSave($context, $table, $isNew, $data)
{
// Check we are handling the frontend edit form.
if ($context === 'com_menus.item') {
return true;
}

Testing Instructions

  • add a new menu item Create Article
  • enable Specific Category under Options
  • do not select a category

Actual result BEFORE applying this Pull Request

menu item is saved
image

Expected result AFTER applying this Pull Request

menu item is not saved and an error message is displayed
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 21 May 2023
Category ⇒ Administration Language & Strings Front End Plugins
avatar heelc29 heelc29 - open - 21 May 2023
avatar heelc29 heelc29 - change - 21 May 2023
Status New ⇒ Pending
avatar ChristineWk ChristineWk - test_item - 21 May 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 May 2023

I have tested this item ✅ successfully on 0df72f0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40637.

avatar viocassel viocassel - test_item - 22 May 2023 - Tested successfully
avatar viocassel
viocassel - comment - 22 May 2023

I have tested this item ✅ successfully on 0df72f0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40637.

avatar richard67 richard67 - change - 23 May 2023
Status Pending ⇒ Ready to Commit
Labels Added: bug Language Change PR-4.3-dev
avatar richard67
richard67 - comment - 23 May 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40637.

avatar obuisard obuisard - change - 2 Jun 2023
Labels Added: ?
avatar obuisard obuisard - change - 2 Jun 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-06-02 19:19:17
Closed_By ⇒ obuisard
avatar obuisard obuisard - close - 2 Jun 2023
avatar obuisard obuisard - merge - 2 Jun 2023
avatar obuisard
obuisard - comment - 2 Jun 2023

Thank you @heelc29 for this PR!

Add a Comment

Login with GitHub to post a comment