[#4059] - [#34036] Fix deleting in JHelperTags for #_ucm_content only entries
- Closed
- 20 Aug 2015
- Medium
- Build: staging
- # 4059
- Diff
- Buddhima:JHelperTags_fix
- Foreign ID 34036
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Hi,
Currently JHelperTags not considering about purely UCM data when deleting last tag. It's just remove entry from #_ucm_content table when saving after removing last tag.
This fix checks the whether $table type is JTableCorecontent and if so, not remove #_ucm_content entry.
Issue Tracker Item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34036&start=0
jissues-bot
- | Labels |
Added:
?
?
|
||
brianteeman
- | Labels |
Added:
?
Removed: ? |
||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
Hi,
Currently ucm only work for tagged items. When a user add tag to an item, then it get inserted in to #_ucm_content. So when user remove last tag, the record at #_ucm_content also need to remove.
Currently there's no component which purely using #_ucm_content table. We can eliminate this if condition once all components start to use UCM.
Yep, currently only tags uses the ucm tables. But given it's UCM you don't know if any other extension uses it as you said. That's why I think it should only delete the tags part of it, and not the UCM part.
But it shows one of the flaws of the implementation.
We can eliminate this if condition once all components start to use UCM.
I don't think that ever happens. At least not with the current implementation.
nicksavov
- | Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
| Category | ⇒ | Tags |
Hi,
I think this PR tries to give the solution according current situation. And this will help extension developers to see how UCM should properly work.
As far as I know, this is not the way UCM was originally planned. Somehow it was restricted to tagged items and as a result of that, this kind of undesired things imposed.
I believe this will help to remove an undesired situation from extension developers who like UCM.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-20 20:03:26 |
| Closed_By | ⇒ | roland-d |
Hello @Buddhima
Thank you for your contribution. As 2 PLT members have strong objections, I am closing this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4059.
I wonder why
deleteTagDataever should delete the UCM part.But then the whole UCM thing is flawed and should seriously be rethinked and not be used by other extensions.