Feeling Lucky
?
bug
PR-4.3-dev
[#40574] - change "navbar navbar-expand-md" to "navbar navbar-expand-lg"
- Fixed in Code Base
- 12 May 2023
- Medium
- Build: 4.3-dev
- # 40574
- Diff
- hans2103:feature/37926
User tests: Successful: Unsuccessful:
Pull Request for Issue #37926
Summary of Changes
This PR will change "navbar navbar-expand-mg" into "navbar navbar-expand-lg"
Testing Instructions
- Reduce screen width and notice that the horizontal menu will change to vertical at 992px
- Reduce even more and notice that the vertical menu will be replaced by a hamburger at 768px
After applying the patch the horizontal menu will be replaced by a hamburger at 992px.
Testing instructions are mentioned in the issue #37926 (comment)
Actual result BEFORE applying this Pull Request
- Until viewport < 768px the hamburger is present.
- From 768px (
md) the hamburger is gone... leaving a vertical menu - From 992px (
lg) the menu is horizontal
Expected result AFTER applying this Pull Request
Hamburger menu will stay until 992px (lg)
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Status | New | ⇒ | Pending |
RensKooijman
- comment
- 12 May 2023
I have tested this item
this was tested succesfully with use of google devtools
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40574.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 12 May 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40574.
obuisard
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-12 14:08:06 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
bug
PR-4.3-dev
|
||
I have tested this item✅ successfully on 5845d46
i have tested this issue successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40574.