a11y PR-4.3-dev ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
12 May 2023

Pull Request for Issue # .
The issue was mentioned in JAT channel by @rytechsites. Thanks for reporting.

Summary of Changes

This PR removes the role attribute from bootstrap accordion. Thanks @drmenzelit.

Testing Instructions

Add a few page breaks into an article, set the layout in the page break plugin to "slider".
Check the result with an a11y tool.

Similar for menu item types modal or other occurrences of accordions

Actual result BEFORE applying this Pull Request

You will get a11y issues for the role attribute.

Expected result AFTER applying this Pull Request

No a11y issues.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2023
Category Libraries
avatar chmst chmst - open - 12 May 2023
avatar chmst chmst - change - 12 May 2023
Status New Pending
avatar drmenzelit drmenzelit - change - 12 May 2023
The description was changed
avatar drmenzelit drmenzelit - edited - 12 May 2023
avatar chmst chmst - change - 12 May 2023
The description was changed
avatar chmst chmst - edited - 12 May 2023
avatar chmst chmst - change - 12 May 2023
The description was changed
avatar chmst chmst - edited - 12 May 2023
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2023
Category Libraries Unit Tests Repository Administration com_admin com_banners com_categories com_config com_contact com_content com_contenthistory com_finder com_installer
avatar obuisard obuisard - change - 12 May 2023
Title
[4.4] Fix a11y issue in accordion
[4.3] Fix a11y issue in accordion
avatar obuisard obuisard - edited - 12 May 2023
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2023
Category Unit Tests Repository Administration com_admin com_banners com_categories com_config com_contact com_content com_contenthistory com_finder com_installer Libraries
avatar obuisard obuisard - change - 12 May 2023
Title
[4.3] Fix a11y issue in accordion
[4.4] Fix a11y issue in accordion
avatar obuisard obuisard - edited - 12 May 2023
avatar chmst chmst - change - 12 May 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-05-12 14:40:08
Closed_By chmst
Labels Added: a11y PR-4.3-dev ? PR-4.4-dev
avatar chmst
chmst - comment - 12 May 2023

Closing this in favour to a PR on 4.3.

avatar chmst chmst - close - 12 May 2023

Add a Comment

Login with GitHub to post a comment