Feeling Lucky
?
NPM Resource Changed
bug
PR-4.3-dev
[#40541] - Cassiopeia missing color
- Fixed in Code Base
- 7 May 2023
- Medium
- Build: 4.3-dev
- # 40541
- Diff
- dgrammatiko:patch-5
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40540
Summary of Changes
Adds the missing var(--black)
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
richard67
- comment
- 7 May 2023
I have tested this item
I've verified that the variable $black is defined here https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/templates/site/cassiopeia/scss/tools/variables/_variables.scss#L32 so the change from this PR is correct.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40541.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
richard67
- comment
- 7 May 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40541.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-07 19:53:42 |
| Closed_By | ⇒ | obuisard |
obuisard
- comment
- 7 May 2023
Thanks Dimitris @dgrammatiko !
I have tested this item✅ successfully on 0b604da
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40541.