[#40537] - [4.4] Deprecated HtmlDocument::countMenuChildren()
- Fixed in Code Base
- 12 May 2023
- Medium
- Build: 4.4-dev
- # 40537
- Diff
- HLeithner:4.4/deprecation/countmenuchildren
User tests: Successful: Unsuccessful:
Summary of Changes
Deprecate HtmlDocument::countMenuChildren() method and rewrite the method to use the menu already loaded menu to count childrens.
This function is not used in the CMS and is conceptional wrong in the HtmlDocument, if it needs to exists it should be part of the menu class. But even this makes not much sense because you simple need to count() the children auf the menu item.
Testing Instructions
Use the countMenuChildren method in the template with $this->countMenuChildren()
Actual result BEFORE applying this Pull Request
Should work.
Expected result AFTER applying this Pull Request
Should be the same value as before.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#117
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.4-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-12 05:41:00 |
| Closed_By | ⇒ | laoneo |
Thanks!