[#40531] - [4.4] Message after a login / logout frontend (2)
- Closed
- 4 May 2023
- Medium
- Build: 4.4-dev
- # 40531
- Diff
- sandewt:patch-4
User tests: Successful: Unsuccessful:
Pull Request for Issue #40458 .
Showing a message by default is perceived as disturbing. There has been a lot of commentary on that, since this feature was recently introduced in J4.3.
Summary of Changes
The "Message after a login/logout frontend" feature turns out to be an unfortunate compromise as the originally pr was intended. See pull request #30834.
In the renewed situation, the login/logout message is disabled by default.
But as 1 switch (to switch both login/logout), instead of 2 as originally intended.
Attention: Because this pr gives a b/c break, is this pr not intended for Joomla 4.3 but for Joomla 4.4. !!!
(Unless there is a good argument to do this also for Joomla 4.3)
Testing Instructions
Backend: Go to Users > Manage > Options
Set the option to Yes: (default = Hide)
- Frontend Login / Logout Message
Login and logout in the frontend:
- There is showing a message after a login
- There is showing a message after a logout
Actual result BEFORE applying this Pull Request
The login / logout message is shown by default.
There is no switch to turn it off.
If you find the message (login/logout) annoying, you can make a language override.
Expected result AFTER applying this Pull Request
The login / logout message is NOT shown by default.
There is a switch to turn it on.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings Front End |
| Labels |
Added:
Feature
Language Change
PR-4.4-dev
|
||
As it's a new feature (and as you mentioned also a b/c break) it can not go into 4.4, it has to go into 5.0 (which will be released at the same time as 4.4).
In fact it is a small change, a switch has been added. But the user expects a login/logout message, which then isn't there unless the switch is flipped.
With this knowledge, does this mean that I should now convert the brache to Joomla 5.0 (if that's easy), or leave it for Joomla 4.4?
As it's a new feature (and as you mentioned also a b/c break) it can not go into 4.4, it has to go into 5.0 (which will be released at the same time as 4.4).
In fact it is a small change, a switch has been added. But the user expects a login/logout message, which then isn't there unless the switch is flipped.
With this knowledge, does this mean that I should now convert the brache to Joomla 5.0 (if that's easy), or leave it for Joomla 4.4?
@sandewt At the end that is to be decided by the release managers.
Thanks for the pr. But an option for a login/logout message is way too much. Either revert the original pr or tell people to make a language override.
But an option for a login/logout message is way too much.
I didn't expect this answer because of the user benefit. Others may of course think differently.
Either revert the original pr or tell people to make a language override.
Seems undesirable, because a message can provide useful information in case of sensitive data. That would be a missed opportunity. Apparently there is resistance to making a language override. Or they are unfamiliar with it.
But an option for a login/logout message is way too much.
I think this PR is okay, the optional feature need an "option", without messing around with language overides and etc.
I have tested this item
For myself it doesn't matter as I'm not a frontend user so I don't know if the frontend users want that. So I just tested it and it's OK :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40531.
I hear it many times that joomla has too many options and it is getting too complex. Now you want to add a new option for a login/logout message? I hope you see the problem or still not?
I hear it many times that joomla has too many options and it is getting too complex. Now you want to add a new option for a login/logout message? I hope you see the problem or still not?
Whether something is complex depends mainly on its functionality. In other words, what exactly does a feature do. In this case, the operation is clear and certainly not complex: message or no message. So the amount of options in Joomla is of secondary importance here.
A language override here causes annoyance for users. With this pr you take away this annoyance. And keep happy Joomla users.
I believe we should revert the login message that we introduced but keep the logout message. No new parameter should be introduced. The workaround should be the use of language overrides. A login message does not really add much value, but a logout message does, that is why I am in favor of keeping the logout message in place.
I hear it many times that joomla has too many options and it is getting too complex.
In my opinion, this is a biased perception.
I agree that many options may confuses, but I do not agree that we should throw it away and stop using Params at all.
The Params offers much easy and safe way to change something, than doing an override for a layout/language for every little thing. Especially for non skilled Users
No new parameter should be introduced. The workaround should be the use of language overrides
Sorry, but this is not acceptable to force Users to mess around with overrides for an optional feature.
PS. Joomla have many options because it easy to add and use them, compared to other CMS. It a big plus.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-04 20:07:26 |
| Closed_By | ⇒ | sandewt |
Thks all.
Note: I have an idea for a new feature.
Show a useful notification after logging in, with the last visit date.
As it's a new feature (and as you mentioned also a b/c break) it can not go into 4.4, it has to go into 5.0 (which will be released at the same time as 4.4).