? PHP 8.x bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
3 May 2023

Summary of Changes

Don't call Joomla\CMS\Uri\Uri::isInternal() on empty redirect URL.

Testing Instructions

PHP 8.1, error reporting maximum, update from Joomla 4.3.0 to 4.3.1

Actual result BEFORE applying this Pull Request

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in \libraries\src\Uri\Uri.php on line 243

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2023
Category Administration com_installer
avatar Denitz Denitz - open - 3 May 2023
avatar Denitz Denitz - change - 3 May 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar Denitz Denitz - change - 3 Oct 2023
Title
str_replace() on NULL in Joomla\CMS\Uri\Uri::isInternal()
[4.4] str_replace() on NULL in Joomla\CMS\Uri\Uri::isInternal()
avatar Denitz Denitz - edited - 3 Oct 2023
avatar alikon alikon - test_item - 5 Nov 2023 - Tested successfully
avatar alikon
alikon - comment - 5 Nov 2023

I have tested this item ✅ successfully on b6a27a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40528.

avatar viocassel viocassel - test_item - 14 Nov 2023 - Tested successfully
avatar viocassel
viocassel - comment - 14 Nov 2023

I have tested this item ✅ successfully on b6a27a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40528.

avatar richard67 richard67 - change - 14 Nov 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 14 Nov 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40528.

avatar MacJoom MacJoom - change - 14 Nov 2023
Labels Added: ? PHP 8.x bug PR-4.4-dev
avatar MacJoom MacJoom - change - 14 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-14 22:54:14
Closed_By MacJoom
Labels Added: ?
Removed: ?
avatar MacJoom MacJoom - close - 14 Nov 2023
avatar MacJoom MacJoom - merge - 14 Nov 2023

Add a Comment

Login with GitHub to post a comment