[#40518] - [4.3] Missing Text
- Fixed in Code Base
- 6 May 2023
- Medium
- Build: 4.3-dev
- # 40518
- Diff
- brianteeman:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue #40517 .
Summary of Changes
@laoneo](https://github.com/laoneo) removed this use statement with #39624. I assuming it was in error
Testing Instructions
see #40517
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
I think this was the intention:
$response->error_message = $this->getApplication()->getLanguage()->_('JLIB_LOGIN_DENIED');
This can then expire again:
use Joomla\CMS\Language\Text;
[EDIT I just missed the previous post]
Tanks @brianteeman for the fast pr. Can you change the pr to the proposal from @dgrammatiko?
| Labels |
Added:
PR-4.3-dev
|
||
I have tested this item
To reproduce the error I had to switch the site to offline in addition to what's described in issue #40517 .
See also #40517 (comment) .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40518.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40518.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40518.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-06 03:01:13 |
| Closed_By | ⇒ | sdwjoomla |
Thanks brianteeman
thanks
Actually the correct solution is to change line 87 from
$_errorMessage = Text::_('JLIB_LOGIN_DENIED');to
$_errorMessage = $this->getApplication()->getLanguage()->_('JLIB_LOGIN_DENIED');